Bug 192008

Summary: [GTK][WPE] Remove temporary workaround in Source/WebKit/Platform*.cmake
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: CMakeAssignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tomas Popela
Reported 2018-11-27 07:02:18 PST
There is a workaround in Source/WebKit/Platform*.cmake that was added in https://trac.webkit.org/changeset/223574: # Temporary workaround to allow the build to succeed. file(REMOVE "${FORWARDING_HEADERS_DIR}/WebCore/Settings.h") Looks like it's not needed anymore as the WebKit compiles fine without it.
Attachments
Patch (2.10 KB, patch)
2018-11-27 07:05 PST, Tomas Popela 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2018-11-27 07:05:03 PST
Created attachment 355730 [details] Patch
Tomas Popela
Comment 2 2018-11-27 07:30:00 PST
Comment on attachment 355730 [details] Patch Clearing flags on attachment: 355730 Committed r238552: <https://trac.webkit.org/changeset/238552>
Tomas Popela
Comment 3 2018-11-27 07:30:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.