Bug 192006

Summary: Record right offset with aligned wide instructions
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dominik.infuehr, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch none

Dominik Inführ
Reported 2018-11-27 05:33:15 PST
Record right offset with aligned wide instructions
Attachments
Patch (6.25 KB, patch)
2018-11-27 05:38 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (5.69 KB, patch)
2018-11-27 05:51 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (5.09 KB, patch)
2018-11-27 06:03 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-11-27 08:22 PST, EWS Watchlist 		no flags
Details
Patch (5.04 KB, patch)
2018-11-28 00:48 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (5.00 KB, patch)
2018-12-07 04:04 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2018-12-07 10:45 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-11-27 05:38:30 PST
Created attachment 355724 [details] Patch
Dominik Inführ
Comment 2 2018-11-27 05:51:14 PST
Created attachment 355725 [details] Patch
Dominik Inführ
Comment 3 2018-11-27 06:03:53 PST
Created attachment 355728 [details] Patch
EWS Watchlist
Comment 4 2018-11-27 08:22:13 PST
Comment on attachment 355728 [details] Patch Attachment 355728 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10166888 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
EWS Watchlist
Comment 5 2018-11-27 08:22:14 PST
Created attachment 355734 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Dominik Inführ
Comment 6 2018-11-28 00:48:09 PST
Created attachment 355858 [details] Patch
Dominik Inführ
Comment 7 2018-12-07 04:04:55 PST
Created attachment 356798 [details] Patch
Dominik Inführ
Comment 8 2018-12-07 06:56:27 PST
This patch is now updated to the latest changes in generator/Opcode.rb.
Yusuke Suzuki
Comment 9 2018-12-07 07:34:31 PST
Comment on attachment 356798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356798&action=review r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2787 > + auto inst = m_lastInstruction; > + m_staticPropertyAnalyzer.createThis(dst, WTFMove(inst)); By changing the signature of `createThis` from `void createThis(RegisterID* dst, InstructionStream::MutableRef&& instructionRef);` to `void createThis(RegisterID* dst, InstructionStream::MutableRef instructionRef);`, we do not need `auto inst = m_lastInstruction;` and `WTFMove` here. > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2899 > + auto inst = m_lastInstruction; > + m_staticPropertyAnalyzer.newObject(dst, WTFMove(inst)); > + Ditto
Dominik Inführ
Comment 10 2018-12-07 10:45:03 PST
Created attachment 356822 [details] Patch
WebKit Commit Bot
Comment 11 2018-12-08 06:57:59 PST
Comment on attachment 356822 [details] Patch Clearing flags on attachment: 356822 Committed r239009: <https://trac.webkit.org/changeset/239009>
WebKit Commit Bot
Comment 12 2018-12-08 06:58:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-12-08 06:58:28 PST
<rdar://problem/46575214>
Note You need to log in before you can comment on or make changes to this bug.