Summary: | Record right offset with aligned wide instructions | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominik Inführ <dominik.infuehr> | ||||||||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | commit-queue, dominik.infuehr, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Dominik Inführ
2018-11-27 05:33:15 PST
Created attachment 355724 [details]
Patch
Created attachment 355725 [details]
Patch
Created attachment 355728 [details]
Patch
Comment on attachment 355728 [details] Patch Attachment 355728 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10166888 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html Created attachment 355734 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 355858 [details]
Patch
Created attachment 356798 [details]
Patch
This patch is now updated to the latest changes in generator/Opcode.rb. Comment on attachment 356798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356798&action=review r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2787 > + auto inst = m_lastInstruction; > + m_staticPropertyAnalyzer.createThis(dst, WTFMove(inst)); By changing the signature of `createThis` from `void createThis(RegisterID* dst, InstructionStream::MutableRef&& instructionRef);` to `void createThis(RegisterID* dst, InstructionStream::MutableRef instructionRef);`, we do not need `auto inst = m_lastInstruction;` and `WTFMove` here. > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2899 > + auto inst = m_lastInstruction; > + m_staticPropertyAnalyzer.newObject(dst, WTFMove(inst)); > + Ditto Created attachment 356822 [details]
Patch
Comment on attachment 356822 [details] Patch Clearing flags on attachment: 356822 Committed r239009: <https://trac.webkit.org/changeset/239009> All reviewed patches have been landed. Closing bug. |