Summary: | REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mart Raudsepp <leio> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, bugs-noreply, cadubentzen, commit-queue, mcatanzaro, pnormand, zan | ||||
Priority: | P3 | Keywords: | Gtk | ||||
Version: | WebKit Local Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=191998 | ||||||
Attachments: |
|
Description
Mart Raudsepp
2018-11-26 23:56:01 PST
The fix for this is not obvious to me, but I guess the build guards are wrong in ScrollingStateNode.h: #if ENABLE(ASYNC_SCROLLING) || USE(COORDINATED_GRAPHICS) Expresses the intent for this file to work if USE(COORDINATED_GRAPHICS) is disabled, but it doesn't. Another option would be to add explicit dependencies at the CMake level if async scrolling really is supposed to depend on coordinated graphics, but they would have to be duplicated in both OptionsGTK.cmake and OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option: WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL) (We also might want to consider removing the ENABLE_OPENGL, option since clearly nobody has attempted to build 2.22 with it disabled before now. It exists only for embedded systems, and we never test building without it. But nowadays we expect embedded systems will mostly want to use WPE, and WPE requires OpenGL, so maybe it doesn't make sense anymore. Not sure.) Created attachment 356698 [details]
Patch
(In reply to Michael Catanzaro from comment #1) > Another option would be to add explicit dependencies at the CMake level if > async scrolling really is supposed to depend on coordinated graphics, but > they would have to be duplicated in both OptionsGTK.cmake and > OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option: > > WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL) Did that in OptionsGTK.cmake but it is not need for WPE because 1) there's no ENABLE_OPENGL for WPE 2) ENABLE_ASYNC_SCROLLING is always on there explicitly (In reply to Carlos Eduardo Ramalho from comment #4) > (In reply to Michael Catanzaro from comment #1) > > Another option would be to add explicit dependencies at the CMake level if > > async scrolling really is supposed to depend on coordinated graphics, but > > they would have to be duplicated in both OptionsGTK.cmake and > > OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option: > > > > WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL) > > Did that in OptionsGTK.cmake but it is not need for WPE because > 1) there's no ENABLE_OPENGL for WPE > 2) ENABLE_ASYNC_SCROLLING is always on there explicitly JFTR, this seems like a reasonably good approach to me. Comment on attachment 356698 [details] Patch Clearing flags on attachment: 356698 Committed r238928: <https://trac.webkit.org/changeset/238928> All reviewed patches have been landed. Closing bug. |