| Summary: | Remove "using namespace WebCore" under Source/WebKit/WebProcess/InjectedBundle/API | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Component: | WebKit2 | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, darin, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 191853, 192449 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Fujii Hironori
2018-11-26 20:20:08 PST
Created attachment 355707 [details]
Patch
Created attachment 355708 [details]
Patch
Created attachment 355709 [details]
Patch
Created attachment 355714 [details]
Patch
Comment on attachment 355714 [details] Patch Rejecting attachment 355714 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355714, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=355714&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191995&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 355714 from bug 191995. Fetching: https://bugs.webkit.org/attachment.cgi?id=355714 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 2573f9f9b69f1f64366c347abef13db6b08cb902 and refs/remotes/origin/master differ, using rebase: :040000 040000 a9d1047455c5ce773b9735903ad79a565409fb62 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 2573f9f9b69f1f64366c347abef13db6b08cb902 and refs/remotes/origin/master differ, using rebase: :040000 040000 a9d1047455c5ce773b9735903ad79a565409fb62 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/10163595 Committed r238546: <https://trac.webkit.org/changeset/238546> Same applies to "using namespace WebKit" and those should be removed for the same reason. Thank you for the feedback. Let's do that in Bug 192301. |