Bug 191995

Summary:

Remove "using namespace WebCore" under Source/WebKit/WebProcess/InjectedBundle/API

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

WebKit2

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

191853, 192449

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	achristensen: review+, commit-queue: commit-queue-

Fujii Hironori

Reported 2018-11-26 20:20:08 PST

Remove "using namespace WebCore" under Source/WebKit/WebProcess/InjectedBundle/API Not break Apple internal build system due to unified source builds such like Bug 191853 Comment 9.

Attachments
Patch (11.17 KB, patch) 2018-11-26 20:52 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (9.79 KB, patch) 2018-11-26 20:57 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (8.68 KB, patch) 2018-11-26 21:01 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (9.08 KB, patch) 2018-11-26 22:00 PST, Fujii Hironori	achristensen: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2018-11-26 20:52:09 PST Comment hidden (obsolete)

Created attachment 355707 [details] Patch

Fujii Hironori

Comment 2 2018-11-26 20:57:22 PST Comment hidden (obsolete)

Created attachment 355708 [details] Patch

Fujii Hironori

Comment 3 2018-11-26 21:01:51 PST Comment hidden (obsolete)

Created attachment 355709 [details] Patch

Fujii Hironori

Comment 4 2018-11-26 22:00:13 PST

Created attachment 355714 [details] Patch

WebKit Commit Bot

Comment 5 2018-11-26 23:50:50 PST

Comment on attachment 355714 [details] Patch Rejecting attachment 355714 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355714, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=355714&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191995&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 355714 from bug 191995. Fetching: https://bugs.webkit.org/attachment.cgi?id=355714 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 2573f9f9b69f1f64366c347abef13db6b08cb902 and refs/remotes/origin/master differ, using rebase: :040000 040000 a9d1047455c5ce773b9735903ad79a565409fb62 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 2573f9f9b69f1f64366c347abef13db6b08cb902 and refs/remotes/origin/master differ, using rebase: :040000 040000 a9d1047455c5ce773b9735903ad79a565409fb62 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/10163595

Fujii Hironori

Comment 6 2018-11-27 00:59:02 PST

Committed r238546: <https://trac.webkit.org/changeset/238546>

Radar WebKit Bug Importer

Comment 7 2018-11-27 01:00:50 PST

<rdar://problem/46270039>

Darin Adler

Comment 8 2018-12-02 21:54:23 PST

Same applies to "using namespace WebKit" and those should be removed for the same reason.

Fujii Hironori

Comment 9 2018-12-03 00:17:46 PST

Thank you for the feedback. Let's do that in Bug 192301.

Note You need to log in before you can comment on or make changes to this bug.