Bug 191974 – webkitpy: Add watchOS ports

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

Add ports for running layout tests on watchOS.

[Radar WebKit Bug Importer]

<rdar://problem/46251051>

[Jonathan Bedard]

Created attachment 355660 [details]
Patch

[Jonathan Bedard]

Created attachment 355668 [details]
Patch

[Lucas Forschler]

Comment on attachment 355668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355668&action=review

> Tools/Scripts/webkitpy/port/watch_device.py:42
> +    NO_ON_DEVICE_TESTING = 'On-device testing is not supported on this machine'

is 'machine' the right noun here?  How about: configuration | device | platform | scenario ?

> Tools/Scripts/webkitpy/port/watch_simulator.py:39
> +    DEFAULT_ARCHITECTURE = 'x86'

I am not certain of watchOS conventions, but other places we use i386, or x86_64.

> Tools/Scripts/webkitpy/port/watch_simulator.py:116
> +        _log.error('No Simulated device matching "{}" found in watchOS SDK'.format(str(target_device_type)))

nit: lower case simulated.

> Tools/Scripts/webkitpy/port/watch_simulator.py:119
> +    def setup_environ_for_server(self, server_name=None):

I think this should be setup_env_for_server, or fully spelled out as setup_environment_for_server

[Aakash Jain]

Comment on attachment 355668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355668&action=review

> Tools/Scripts/webkitpy/port/watch.py:23
> +

Nit: Do we need 2 or 1 empty lines here?

> Tools/Scripts/webkitpy/port/watch.py:103
> +        # The implementation of this funciton differs between on-device and simulator testing.

typo: funciton => function

[Jonathan Bedard]

Comment on attachment 355668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355668&action=review

>> Tools/Scripts/webkitpy/port/watch_simulator.py:39
>> +    DEFAULT_ARCHITECTURE = 'x86'
> 
> I am not certain of watchOS conventions, but other places we use i386, or x86_64.

Testing this now, pretty sure you're right and i386 is required.

>> Tools/Scripts/webkitpy/port/watch_simulator.py:119
>> +    def setup_environ_for_server(self, server_name=None):
> 
> I think this should be setup_env_for_server, or fully spelled out as setup_environment_for_server

This function is coming from a base class, so we shouldn't change it's name here.

[Jonathan Bedard]

Created attachment 355800 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355800 [details]
Patch for landing

Clearing flags on attachment: 355800

Committed r238590: <https://trac.webkit.org/changeset/238590>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.