Bug 191971

Summary: Web Inspector: REGRESSION(r238378): reloading WebInspector after a settings change doesn't re-show WebInspector
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191773
Attachments:
Description Flags
[PATCH] Proposed Fix
mattbaker: review+, joepeck: commit-queue-
[PATCH] Proposed Fix none

Description Devin Rousso 2018-11-26 10:29:37 PST 
* STEPS TO REPRODUCE:
1. Open WebInspector
2. Go to the Settings tab
3. Check/Uncheck any setting that requires a reload (e.g. any experimental setting for enabling a tab)
4. Click "Reload Web Inspector"
 => WebInspector closes and doesn't re-show
Comment 1 Joseph Pecoraro 2018-11-27 15:21:11 PST 
Created attachment 355794 [details]
[PATCH] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2018-11-27 15:25:41 PST 
<rdar://problem/46291183>
Comment 3 Matt Baker 2018-11-27 15:32:11 PST 
Comment on attachment 355794 [details]
[PATCH] Proposed Fix

r=me
Comment 4 Joseph Pecoraro 2018-11-27 16:14:22 PST 
Comment on attachment 355794 [details]
[PATCH] Proposed Fix

Hmm this has a bit of a problem in that close() triggers a DidClose message from the WebProcess which may cause us to try to disconnect after we establish a connection here... A debug build asserts. Let me try something else.
Comment 5 Joseph Pecoraro 2018-11-27 17:02:11 PST 
Created attachment 355824 [details]
[PATCH] Proposed Fix

Avoid calling a disconnectFrontend unless we were actually connected.
Comment 6 Matt Baker 2018-11-27 17:05:55 PST 
Comment on attachment 355824 [details]
[PATCH] Proposed Fix

r=me
Comment 7 WebKit Commit Bot 2018-11-28 09:51:56 PST 
Comment on attachment 355824 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 355824

Committed r238617: <https://trac.webkit.org/changeset/238617>
Comment 8 WebKit Commit Bot 2018-11-28 09:51:58 PST 
All reviewed patches have been landed.  Closing bug.