Summary: | REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Layout and Rendering | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, dino, ryanhaddad, simon.fraser, tsavell, webkit-bug-importer, wenson_hsieh, zalan | ||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||
Version: | WebKit Local Build | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | iOS 12 | ||||||
Bug Depends on: | 190565 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Daniel Bates
2018-11-26 10:05:43 PST
Created attachment 355650 [details]
Patch and layout tests
Comment on attachment 355650 [details] Patch and layout tests Clearing flags on attachment: 355650 Committed r238513: <https://trac.webkit.org/changeset/238513> All reviewed patches have been landed. Closing bug. The new test fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html is failing constantly after being added. the diff shows the I beam is in the wrong place in the password field. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html Diff: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238522%20(1020)/fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button-diffs.html (In reply to Truitt Savell from comment #5) > The new test > fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after- > hiding-auto-fill-strong-password-button.html is failing constantly after > being added. > > the diff shows the I beam is in the wrong place in the password field. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock- > indicator-should-be-visible-when-after-hiding-auto-fill-strong-password- > button.html > > Diff: > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/ > r238522%20(1020)/fast/forms/auto-fill-button/caps-lock-indicator-should-be- > visible-when-after-hiding-auto-fill-strong-password-button-diffs.html Skip the test for now. Will fix the test shortly. (In reply to Daniel Bates from comment #6) > (In reply to Truitt Savell from comment #5) > > The new test > > fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after- > > hiding-auto-fill-strong-password-button.html is failing constantly after > > being added. > > > > the diff shows the I beam is in the wrong place in the password field. > > > > History: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock- > > indicator-should-be-visible-when-after-hiding-auto-fill-strong-password- > > button.html > > > > Diff: > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/ > > r238522%20(1020)/fast/forms/auto-fill-button/caps-lock-indicator-should-be- > > visible-when-after-hiding-auto-fill-strong-password-button-diffs.html > > Skip the test for now. Will fix the test shortly. We shouldn't skip brand new tests. I think we should roll out this change and re-land it with a working test. (In reply to Ryan Haddad from comment #7) > (In reply to Daniel Bates from comment #6) > > (In reply to Truitt Savell from comment #5) > > > The new test > > > fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after- > > > hiding-auto-fill-strong-password-button.html is failing constantly after > > > being added. > > > > > > the diff shows the I beam is in the wrong place in the password field. > > > > > > History: > > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > > html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock- > > > indicator-should-be-visible-when-after-hiding-auto-fill-strong-password- > > > button.html > > > > > > Diff: > > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/ > > > r238522%20(1020)/fast/forms/auto-fill-button/caps-lock-indicator-should-be- > > > visible-when-after-hiding-auto-fill-strong-password-button-diffs.html > > > > Skip the test for now. Will fix the test shortly. > We shouldn't skip brand new tests. I think we should roll out this change > and re-land it with a working test. Feel free to roll it out. Rolled out in https://trac.webkit.org/changeset/238540/webkit Committed r238545: <https://trac.webkit.org/changeset/238545> The new test fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button.html added in https://trac.webkit.org/changeset/238545/webkit is timing out at around 300 seconds on Mojave WK2. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button.html (In reply to Truitt Savell from comment #11) > The new test > fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after- > hiding-auto-fill-strong-password-button.html > > added in https://trac.webkit.org/changeset/238545/webkit > > is timing out at around 300 seconds on Mojave WK2. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock- > indicator-should-be-visible-after-hiding-auto-fill-strong-password-button. > html Fixing (In reply to Daniel Bates from comment #12) > (In reply to Truitt Savell from comment #11) > > The new test > > fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after- > > hiding-auto-fill-strong-password-button.html > > > > added in https://trac.webkit.org/changeset/238545/webkit > > > > is timing out at around 300 seconds on Mojave WK2. > > > > History: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=fast%2Fforms%2Fauto-fill-button%2Fcaps-lock- > > indicator-should-be-visible-after-hiding-auto-fill-strong-password-button. > > html > > Fixing Committed fix in <https://trac.webkit.org/changeset/238571>. |