Bug 191953 – Remote tile layers shouldn't be UIViews

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Antti Koivisto]

They don't need any UIView functionality, nor do they ever have UIView children.

[Antti Koivisto]

Created attachment 355592 [details]
patch

[Antti Koivisto]

Created attachment 355594 [details]
patch

[Antti Koivisto]

Created attachment 355598 [details]
patch

[Antti Koivisto]

Created attachment 355599 [details]
patch

[EWS Watchlist]

Comment on attachment 355599 [details]
patch

Attachment 355599 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10149492

New failing tests:
media/no-fullscreen-when-hidden.html

[EWS Watchlist]

Created attachment 355616 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tim Horton]

Comment on attachment 355599 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355599&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:75
> +    if (uiView()) {

Maybe grab it and store it in a local? ('if (auto view = uiView()) [view removeFromSuperview];') It likely doesn't matter, but it seems nicer.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:95
> +NSString* RemoteLayerTreeNode::appendLayerDescription(NSString* description, CALayer* layer)

Star's on the wrong side. (seems like this file is full of that)

[Antti Koivisto]

Created attachment 355623 [details]
patch

[Antti Koivisto]

The test failure appears to be unrelated to the patch.

[Antti Koivisto]

Created attachment 355624 [details]
patch

[Antti Koivisto]

Created attachment 355625 [details]
patch

[Antti Koivisto]

Created attachment 355715 [details]
for landing

[WebKit Commit Bot]

Comment on attachment 355715 [details]
for landing

Rejecting attachment 355715 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355715, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355715&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191953&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 355715 from bug 191953.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355715
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 733d610d44c275bb4138692d9fca9ef1a08bcbe6 and refs/remotes/origin/master differ, using rebase:
:040000 040000 e893bc8c5fe9a192314f828eaf9e298120331367 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 733d610d44c275bb4138692d9fca9ef1a08bcbe6 and refs/remotes/origin/master differ, using rebase:
:040000 040000 e893bc8c5fe9a192314f828eaf9e298120331367 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/10163876

[Antti Koivisto]

https://trac.webkit.org/changeset/238547/webkit

[Radar WebKit Bug Importer]

<rdar://problem/46270321>