Bug 191947 – [ews-app] Fetch bugs from Bugzilla and submit to Buildbot

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

ews-app should fetch bugs from Bugzilla and submit to Buildbot appropriately.

[Aakash Jain]

Created attachment 355729 [details]
Proposed patch

[Kocsen Chung]

Comment on attachment 355729 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355729&action=review

> Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:32
> +class Fetcher():

Should we call this BugzillaPatchFetcher for descriptiveness?

> Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:63
> +    def validate_patch_ids(cls, patch_ids):

Since it's not only validating but also removing we can probably call this: `filter_valid_patches(cls, patch_ids)`.

> Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:66
> +                patch_ids.remove(patch_id)

Sounds like we can use `filter()` for this.

Something like:

```python
return list(filter(lambda p: Patch.is_valid_patch_id(patch_id), patch_ids))
```

[Aakash Jain]

Created attachment 355861 [details]
Updated patch

> Should we call this BugzillaPatchFetcher for descriptiveness?
Changed. Not sure if we should rename the file as well. It would be too long for file name. I guess we can leave the file name as is.

> Since it's not only validating but also removing we can probably call this: `filter_valid_patches(cls, patch_ids)`.
Done.

> Sounds like we can use `filter()` for this.
Done.

[Lucas Forschler]

Comment on attachment 355861 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355861&action=review

R+ with minor nit.

> Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:56
> +                #FIXME: sent an email for this failure

nit: s/sent/send

[Aakash Jain]

Committed r238644: <http://trac.webkit.org/changeset/238644>

[Radar WebKit Bug Importer]

<rdar://problem/46321611>