Bug 191941
| Summary: | [GTK] Disable the sampling profiler by default if the JIT is off | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alberto Garcia
ENABLE_SAMPLING_PROFILER is on by default but it conflicts with ENABLE_C_LOOP, so the build fails on platform where the JIT is not supported, like x86:
This is what happens with WebKitGTK+ 2.23.1:
CMake Error at Source/cmake/WebKitFeatures.cmake:252 (message):
ENABLE_SAMPLING_PROFILER conflicts with ENABLE_C_LOOP. You must disable
one or the other.
Call Stack (most recent call first):
Source/cmake/WebKitFeatures.cmake:260 (_WEBKIT_OPTION_ENFORCE_CONFLICTS)
Source/cmake/WebKitFeatures.cmake:285 (_WEBKIT_OPTION_ENFORCE_ALL_CONFLICTS)
Source/cmake/OptionsGTK.cmake:162 (WEBKIT_OPTION_END)
Source/cmake/WebKitCommon.cmake:59 (include)
CMakeLists.txt:163 (include)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
It's set properly in WebKitFeatures.cmake, so we just need to not override it in OptionsGTK.cmake. It's easiest to handle this in bug #186722.
*** This bug has been marked as a duplicate of bug 186722 ***