Summary: | Scrolling and drawing compete for incoming gestures | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, mitz, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2018-11-24 02:04:26 PST
Created attachment 355561 [details]
Patch
Comment on attachment 355561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355561&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:670 > + [[_scrollView panGestureRecognizer] setAllowedTouchTypes:@[ @(UITouchTypeDirect) ]]; Nit - [~].allowedTouchTypes = ~; > Source/WebKit/UIProcess/ios/WKDrawingView.mm:65 > + [[_pencilView drawingGestureRecognizer] setAllowedTouchTypes:@[ @(UITouchTypePencil) ]]; Ditto. Created attachment 355589 [details]
Patch
Created attachment 355590 [details]
Patch
Comment on attachment 355590 [details] Patch Clearing flags on attachment: 355590 Committed r238474: <https://trac.webkit.org/changeset/238474> All reviewed patches have been landed. Closing bug. |