Bug 191940

Summary: Scrolling and drawing compete for incoming gestures
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2018-11-24 02:04:26 PST
Scrolling and drawing compete for incoming gestures
Attachments
Patch (2.75 KB, patch)
2018-11-24 02:05 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2018-11-25 03:05 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2018-11-25 03:07 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-11-24 02:05:12 PST
Created attachment 355561 [details] Patch
Wenson Hsieh
Comment 2 2018-11-24 10:02:30 PST
Comment on attachment 355561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355561&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:670 > + [[_scrollView panGestureRecognizer] setAllowedTouchTypes:@[ @(UITouchTypeDirect) ]]; Nit - [~].allowedTouchTypes = ~; > Source/WebKit/UIProcess/ios/WKDrawingView.mm:65 > + [[_pencilView drawingGestureRecognizer] setAllowedTouchTypes:@[ @(UITouchTypePencil) ]]; Ditto.
Tim Horton
Comment 3 2018-11-25 03:05:59 PST
Created attachment 355589 [details] Patch
Tim Horton
Comment 4 2018-11-25 03:07:45 PST
Created attachment 355590 [details] Patch
WebKit Commit Bot
Comment 5 2018-11-25 04:05:09 PST
Comment on attachment 355590 [details] Patch Clearing flags on attachment: 355590 Committed r238474: <https://trac.webkit.org/changeset/238474>
WebKit Commit Bot
Comment 6 2018-11-25 04:05:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-25 04:06:33 PST
<rdar://problem/46230894>
Note You need to log in before you can comment on or make changes to this bug.