Bug 191930

Summary: Radial gradient with href sometimes doesn't paint in WK1 or with the very first layout in WK2
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: dino, karlcow, koivisto, megan_gardner, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191934
Attachments:
Description Flags
Reduction
none
rendering in safari, firefox, chrome none

Ryosuke Niwa
Reported 2018-11-23 16:49:23 PST
When href content attribute is used on radial gradient to copy attributes from another radial gradient, the very first paint / layout in MiniBrowser and DumpRenderTree doesn't reference to it. The problem doesn't seem to reproduce in Safari perhaps because it triggers multiple layouts.
Attachments
Reduction (546 bytes, text/html)
2018-11-23 16:52 PST, Ryosuke Niwa 		no flags
Details
rendering in safari, firefox, chrome (121.97 KB, image/png)
2026-01-13 23:21 PST, Karl Dubost 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-11-23 16:52:26 PST
Created attachment 355541 [details] Reduction To reproduce the bug, open the attached bug in MiniBrowser. The issue reproduces the very first time the document is loaded. It appears that reproducing the problem requires a new WK2 window. In WK1, the green box never appears regardless of how many window sizes I trigger so that's a pretty serious bug.
Ryosuke Niwa
Comment 2 2018-11-23 16:53:30 PST
Oops, I initially thought this is a very recent regression but it's not that. The bug simply doesn't reproduce in Safari.
Ryosuke Niwa
Comment 3 2018-11-23 17:00:36 PST
There are suspicious early exists for when renderer() is null in SVGRadialGradientElement::collectGradientAttributes but removing them didn't fix the issue. There is some kind of dependency resolution that's broken here since the bug doesn't reproduce if href isn't specified on radial gradient.
Ryosuke Niwa
Comment 4 2018-11-23 17:47:41 PST
Hm... tests like LayoutTests/svg/custom/radialGradient-focal-radius.svg is working so it's only the subset of features that don't quite work.
Ryosuke Niwa
Comment 5 2018-11-23 17:55:37 PST
It looks like updating href content attribute doesn't update the rendering at all: https://bugs.webkit.org/show_bug.cgi?id=191934 I suspect these two bugs are related.
Simon Fraser (smfr)
Comment 6 2018-11-27 20:13:38 PST
*** Bug 192068 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 7 2018-11-27 20:14:01 PST
It paints when we paint with accelerated drawing, but not when we don't.
Simon Fraser (smfr)
Comment 8 2018-11-27 20:17:55 PST
<rdar://problem/46298791>
Radar WebKit Bug Importer
Comment 9 2018-12-12 14:25:51 PST
<rdar://problem/46675465>
Karl Dubost
Comment 10 2026-01-13 23:21:07 PST
Created attachment 478004 [details] rendering in safari, firefox, chrome Renders the same everywhere
Karl Dubost
Comment 11 2026-01-13 23:21:52 PST
Ryosuke, do you think this is still happening?
Note You need to log in before you can comment on or make changes to this bug.