Bug 191928

Summary: [ews-app] Add methods to save patch to database
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2018-11-23 16:17:33 PST
We should add methods in ews/models/patch.py allowing to save a Patch to database after performing necessary verification on input data.
Attachments
Proposed patch (3.40 KB, patch)
2018-11-23 18:57 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-11-23 18:57:25 PST
Created attachment 355546 [details] Proposed patch
Json
Comment 2 2018-11-26 12:31:55 PST
Comment on attachment 355546 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355546&action=review lgtm, other than the refactor of patchid to patch_id. > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:45 > + def save_patch(cls, patchid, bug_id=-1, obsolete=False): can we use patch_id instead of patchid ? > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:63 > + if not patchid or type(patchid) != int or patchid < 0: rare edge case...but could we have a patchid of 0? maybe this should be "patchid < 1" ?
Lucas Forschler
Comment 3 2018-11-26 12:45:39 PST
Comment on attachment 355546 [details] Proposed patch lgtm, other than the refactor of patchid to patch_id.
Kocsen Chung
Comment 4 2018-11-26 14:45:33 PST
Comment on attachment 355546 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355546&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:45 >> + def save_patch(cls, patchid, bug_id=-1, obsolete=False): > > can we use patch_id instead of patchid ? ++
Aakash Jain
Comment 5 2018-11-26 14:52:25 PST
> can we use patch_id instead of patchid ? Sure, will use patch_id. > rare edge case...but could we have a patchid of 0? maybe this should be "patchid < 1" ? Sure, will change.
Aakash Jain
Comment 6 2018-11-26 16:24:06 PST
Committed r238529: <http://trac.webkit.org/changeset/238529>
Radar WebKit Bug Importer
Comment 7 2018-11-26 16:25:30 PST
<rdar://problem/46260973>
Note You need to log in before you can comment on or make changes to this bug.