Bug 191920

Summary: Updating href on textPath doesn't update its rendering
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: SVGAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, koivisto, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174977    
Attachments:
Description Flags
Fixes the bug
dino: review+
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Ryosuke Niwa
Reported 2018-11-22 21:36:07 PST
When textPath is associated with a given path, updating its href doesn't update the rendering.
Attachments
Fixes the bug (3.57 KB, patch)
2018-11-22 21:38 PST, Ryosuke Niwa 		dino: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.47 MB, application/zip)
2018-11-22 23:46 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-11-22 21:38:39 PST
Created attachment 355497 [details] Fixes the bug
EWS Watchlist
Comment 2 2018-11-22 23:45:58 PST
Comment on attachment 355497 [details] Fixes the bug Attachment 355497 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10115787 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
EWS Watchlist
Comment 3 2018-11-22 23:46:00 PST
Created attachment 355498 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Ryosuke Niwa
Comment 4 2018-11-23 00:15:55 PST
Not sure what's up with iOS EWS but I'm pretty certain the test failure isn't anything to do with my patch.
Ryosuke Niwa
Comment 5 2018-11-23 13:59:56 PST
Thanks for the reviews!
Ryosuke Niwa
Comment 6 2018-11-23 14:06:36 PST
Committed r238464: <https://trac.webkit.org/changeset/238464>
Radar WebKit Bug Importer
Comment 7 2018-11-23 14:07:25 PST
<rdar://problem/46224453>
Note You need to log in before you can comment on or make changes to this bug.