Bug 191889 – [css-grid] Fix grid container sizing under min-content height

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

Created attachment 355414 [details]
Example to reproduce the issue

Open the attached example, it's a grid container with "height: min-content" and "grid-template-rows: minmax(50px, 100px)".
The output should be a 100x100 green square, but it's a 100x50 rectangle.
BTW, this works fine in Firefox (we need to use -moz-min-content there).

We're behaving the same for "height: min-content" than for "width: min-content", but that's wrong per spec (https://drafts.csswg.org/css-sizing/#valdef-width-min-content):
  "min-content
    If specified for the inline axis, use the min-content inline size; otherwise behaves as the property’s initial value."

In the block axis "height: min-content" should behave like "height: auto".

[Manuel Rego Casasnovas]

Created attachment 355416 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 355416 [details]
Patch

Awesome thanks. Happy to see all that hacky code being removed. Glad that the specs specify a sensible and compatible behaviour now.

[Manuel Rego Casasnovas]

Created attachment 355507 [details]
Rebased patch for landing

[EWS Watchlist]

Comment on attachment 355507 [details]
Rebased patch for landing

Attachment 355507 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10120111

New failing tests:
webanimations/leak-document-with-web-animation.html

[EWS Watchlist]

Created attachment 355523 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Manuel Rego Casasnovas]

Comment on attachment 355507 [details]
Rebased patch for landing

win EWS failure is unrelated.

[WebKit Commit Bot]

Comment on attachment 355507 [details]
Rebased patch for landing

Rejecting attachment 355507 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355507, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355507&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191889&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355507 from bug 191889.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355507
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 11 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderGrid.cpp
Hunk #1 FAILED at 245.
1 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderGrid.cpp.rej
patching file Source/WebCore/rendering/RenderGrid.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/imported/w3c/ChangeLog
patching file LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt
patching file LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html
patching file LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001.html
patching file LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/w3c-import.log

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10122076

[Manuel Rego Casasnovas]

Created attachment 355538 [details]
Rebased patch for landing

[WebKit Commit Bot]

Comment on attachment 355538 [details]
Rebased patch for landing

Clearing flags on attachment: 355538

Committed r238488: <https://trac.webkit.org/changeset/238488>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46238029>