Bug 191833

Summary: Avoid potential longer than expected layer flush delays
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2018-11-19 05:21:10 PST
Layer flush throttling also stops style recalcs and layouts. Layouts schedule layer flushes. Especially on a slow network we can in principle end up in situation where layer flush timer fires but there is no flush scheduled and so nothing happens. However there is a pending style recalc or layout that would actually schedule a flush (in practice various things force style recalcs and this doesn't occur commonly). To avoid this we should flush unconditionally when the flush timer fires. This performs any pending style recalc and layout too. If there is nothing to do the flush will be cheap.
Attachments
patch (5.15 KB, patch)
2018-11-19 05:37 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-11-19 05:37:49 PST
Created attachment 355275 [details] patch
WebKit Commit Bot
Comment 2 2018-11-20 01:02:35 PST
Comment on attachment 355275 [details] patch Clearing flags on attachment: 355275 Committed r238394: <https://trac.webkit.org/changeset/238394>
WebKit Commit Bot
Comment 3 2018-11-20 01:02:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-11-20 01:03:32 PST
<rdar://problem/46181098>
Note You need to log in before you can comment on or make changes to this bug.