Bug 191830

Summary: Disable tests on systems without WebAssembly enabled
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, guijemont, keith_miller, mark.lam, mcatanzaro, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Dominik Inführ 2018-11-19 01:27:06 PST 
Disable tests on systems without WebAssembly enabled
Comment 1 Dominik Inführ 2018-11-19 01:30:40 PST 
Created attachment 355259 [details]
Patch
Comment 2 Mark Lam 2018-11-19 11:23:48 PST 
Dominik, if the issue has already been fixed, you should:
1. include the URL of the revision that fixed the issue.  In this case, that would be:
   https://trac.webkit.org/changeset/238373/webkit
2. Clear the flags on your patch so that they don't stay at r? and cq?.

For tests that relies on wasm like this, the better fix is to put them in the JSTests/wasm/stress/ or JSTests/wasm/regress/ directories instead.  You don't need an isWebAssemblyEnabled flag.

Guillaume's fix is certainly still valid to indicate that the test is memory hungry.
Comment 3 Mark Lam 2018-11-19 11:24:28 PST 
Comment on attachment 355259 [details]
Patch

Clearing flags to get this patch out of the review queue.
Comment 4 Radar WebKit Bug Importer 2018-11-19 11:25:23 PST 
<rdar://problem/46171612>
Comment 5 Dominik Inführ 2018-11-20 00:56:38 PST 
Thanks, will certainly do that the next time!