Summary: | Regression(r238330): A lot of WebInspector tests are crashing on the bots | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, rniwa, ryanhaddad, timothy, tsavell, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=191812 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 191740 | ||||||||
Attachments: |
|
Description
Chris Dumez
2018-11-17 14:20:04 PST
ASSERT(!hasRemoteFrontend()); in InspectorController::show(). Created attachment 355254 [details]
[PATCH] Proposed Fix
I don't know how I did not catch this in my own local testing or EWS when the patch first went up... Comment on attachment 355254 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=355254&action=review > Source/WebKit/UIProcess/WebPageInspectorTargetAgent.h:32 > +class WebPageInspectorTargetAgent final : public Inspector::InspectorTargetAgent, Inspector::FrontendChannel { Shouldn’t this be public inheritance? (In reply to Joseph Pecoraro from comment #3) > I don't know how I did not catch this in my own local testing or EWS when > the patch first went up... There is no debug wk2 EWS. Comment on attachment 355254 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=355254&action=review >> Source/WebKit/UIProcess/WebPageInspectorTargetAgent.h:32 >> +class WebPageInspectorTargetAgent final : public Inspector::InspectorTargetAgent, Inspector::FrontendChannel { > > Shouldn’t this be public inheritance? Ahh, yes I'll do that. Created attachment 355256 [details]
[PATCH] Proposed Fix
Comment on attachment 355256 [details] [PATCH] Proposed Fix Clearing flags on attachment: 355256 Committed r238370: <https://trac.webkit.org/changeset/238370> All reviewed patches have been landed. Closing bug. |