Summary: | [MSE][GStreamer] Refactor AppendPipeline deinitialization | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alicia Boya García <aboya> | ||||
Component: | WebKitGTK | Assignee: | Alicia Boya García <aboya> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, calvaris, commit-queue, eocanha | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alicia Boya García
2018-11-16 11:06:30 PST
Created attachment 355078 [details]
Patch
Patch looks ok to me. Anyway, I'd like Enrique to have a quick look at this as well. The patch looks good, but I suspected about problems coming from other threads still processing appends (it happened in the past). Alicia's explanations about how the new AbortableTaskQueue would prevent non-main threads from accessing the append pipeline when it's being destroyed convinced me. She also tested player destruction in a 100 iterations loop while appends are still ongoing and didn't detect any problem related to the pipeline destruction. I think the patch is good to be committed. Comment on attachment 355078 [details] Patch Clearing flags on attachment: 355078 Committed r238412: <https://trac.webkit.org/changeset/238412> All reviewed patches have been landed. Closing bug. |