Bug 191754

Summary: Add DidFirstMeaningfulPaint milestone.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, saam, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2018-11-16 10:21:17 PST
This milestone fires when we finished the very first paint triggered by the first visually non-empty layout.
Attachments
Patch (24.84 KB, patch)
2018-11-16 12:14 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (27.22 KB, patch)
2018-11-16 13:20 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-11-16 12:14:03 PST
Created attachment 355096 [details] Patch
Saam Barati
Comment 2 2018-11-16 12:25:55 PST
Comment on attachment 355096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355096&action=review LGTM but I'll let someone with more domain knowledge give the r+ > Source/WebCore/ChangeLog:8 > + This milestone fires soone after the paint, triggered by the visually non-empty layout is finished. soone => soon > Tools/TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp:2 > + * Copyright (C) 2012 Apple Inc. All rights reserved. 2018 > Tools/TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp:52 > +static InjectedBundleTest::Register<FirstMeaningfulPaintMilestoneTest> registrar("FirstMeaningfulPaintMilestoneTest"); Maybe I'm missing something but what is this testing?
Wenson Hsieh
Comment 3 2018-11-16 12:30:35 PST
Comment on attachment 355096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355096&action=review > Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h:42 > + WKPageRenderingProgressEventFirstMeaningfulPaint = 1 << 8 Hm...why legacy C API instead of modern ObjC API? (see _WKRenderingProgressEvents.h) > Tools/TestWebKitAPI/CMakeLists.txt:234 > + ${TESTWEBKITAPI_DIR}/Tests/WebKit/FirstMeaningfulPaintMileston_Bundle.cpp FirstMeaningfulPaintMileston_Bundle => FirstMeaningfulPaintMilestone_Bundle
Simon Fraser (smfr)
Comment 4 2018-11-16 12:59:15 PST
Comment on attachment 355096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355096&action=review >> Source/WebCore/ChangeLog:8 >> + This milestone fires soone after the paint, triggered by the visually non-empty layout is finished. > > soone => soon "triggered by the visually non-empty layout is finished" doesn't parse. "triggered by the first visually non-empty layout"?
alan
Comment 5 2018-11-16 13:20:11 PST
Created attachment 355107 [details] Patch
WebKit Commit Bot
Comment 6 2018-11-16 14:54:29 PST
Comment on attachment 355107 [details] Patch Clearing flags on attachment: 355107 Committed r238306: <https://trac.webkit.org/changeset/238306>
WebKit Commit Bot
Comment 7 2018-11-16 14:54:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-16 14:55:30 PST
<rdar://problem/46140654>
Saam Barati
Comment 9 2018-11-16 15:00:41 PST
Comment on attachment 355107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355107&action=review > Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h:42 > + WKPageRenderingProgressEventFirstMeaningfulPaint = 1 << 8 Should this be << 6?
alan
Comment 10 2018-11-16 16:45:11 PST
Comment on attachment 355107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355107&action=review >> Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h:42 >> + WKPageRenderingProgressEventFirstMeaningfulPaint = 1 << 8 > > Should this be << 6? No, it needs to value match the other defines.
Note You need to log in before you can comment on or make changes to this bug.