Summary: | ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
Component: | WebKit Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, cdumez, commit-queue, jmulani, koivisto, rniwa, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=196029 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 191083 | ||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2018-11-15 21:43:56 PST
A bit odd since we add in the constructor and remove in the destructor. Maybe something else emptied out the map? *** Bug 191780 has been marked as a duplicate of this bug. *** More practical steps to reproduce in bug 191780. Possibly a recent regression, given that both reports are recent. Chris, is this related to r237615? Could be related to PSON or process prewarming if this is recent. I'll investigate. After clicking the reload button in Safari I see: CHRIS: addMessageReceiver(1, 0x7fce56c3dd90), process is 0x1324e3400 Then we killing the process I see: CHRIS: removeMessageReceiver(1, 0x7fce56c3dd90) process is 0x135ce1400 I added itself as a message receiver from one process and is trying to unregister itself from another. Yes, this is a PSON regression. This is due to us not destroying the gesture controller in WebViewImpl::processWillSwap(). We only do it in WebViewImpl::processDidExit(). We did this to fix Bug 191083. I will fix it shortly. Created attachment 355200 [details]
API test
Created attachment 355201 [details]
Patch
Comment on attachment 355201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355201&action=review Looks sane to me. I guess we should wait for EWS. > Source/WebKit/ChangeLog:10 > + after we've relaunched a new Webprocess. The ViewGestureController controller takes care Nit: Web*P*rocess. > Source/WebKit/ChangeLog:19 > + To address the issue, we now take sure the ViewGestureController unregisters itself from we now *make* sure? Created attachment 355204 [details]
Patch
Created attachment 355207 [details]
Patch
Comment on attachment 355207 [details] Patch Clearing flags on attachment: 355207 Committed r238356: <https://trac.webkit.org/changeset/238356> All reviewed patches have been landed. Closing bug. |