Bug 191717

Summary:

[GTK] Add gbm dependency to install-dependencies

Product:

WebKit

Reporter:

Patrick Griffis <pgriffis>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

agomez, bugs-noreply, clopez, ews-watchlist, ltilve, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[GTK] Add gbm dependency to install-dependencies	mcatanzaro: review+, mcatanzaro: commit-queue-

Patrick Griffis

Reported 2018-11-15 14:28:26 PST

Just a missing dependency in the script on Fedora 29.

Attachments
[GTK] Add gbm dependency to install-dependencies (1.07 KB, patch) 2018-11-15 14:29 PST, Patrick Griffis	mcatanzaro: review+ mcatanzaro: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick Griffis

Comment 1 2018-11-15 14:29:39 PST

Created attachment 354988 [details] [GTK] Add gbm dependency to install-dependencies

Michael Catanzaro

Comment 2 2018-11-15 14:39:22 PST

Comment on attachment 354988 [details] [GTK] Add gbm dependency to install-dependencies What was this needed to build? It's probably needed in Tools/wpe/install-dependencies too, right? Looks like it's already listed for Debian, and I can't find an equivalent package for Arch. So this looks fine once we determine whether WPE needs to be added.

Patrick Griffis

Comment 3 2018-11-15 14:45:06 PST

(In reply to Michael Catanzaro from comment #2) > What was this needed to build? Sorry but that build failure is long out of my terminal history so I don't know offhand. > It's probably needed in Tools/wpe/install-dependencies too, right? Seems likely. This does seem kinda questionable because looking in the build directory we have: ``` ./Build/Mesa/src/gbm ./Build/Mesa/src/gbm/.libs/libgbm.so.1.0.0 ./Build/Mesa/src/gbm/.libs/libgbm.so ./Build/Mesa/src/gbm/.libs/libgbm.lai ./Build/Mesa/src/gbm/.libs/libgbm.so.1 ./Build/Mesa/src/gbm/.libs/libgbm.la ./Build/Mesa/src/gbm/main/.deps/gbm.Plo ./Build/Mesa/src/gbm/main/gbm.pc ./Build/Mesa/src/gbm/main/.libs/gbm.o ./Build/Mesa/src/gbm/main/gbm.lo ./Build/Mesa/src/gbm/backends/dri/.deps/gbm_dri.Plo ./Build/Mesa/src/gbm/backends/dri/.libs/gbm_dri.o ./Build/Mesa/src/gbm/backends/dri/gbm_dri.lo ./Build/Mesa/src/gbm/libgbm.la ./Build/Mesa/lib/libgbm.so.1.0.0 ./Build/Mesa/lib/libgbm.so ./Build/Mesa/lib/libgbm.so.1 ./Root/softGL/include/gbm.h ./Root/softGL/lib/libgbm.so.1.0.0 ./Root/softGL/lib/libgbm.so ./Root/softGL/lib/libgbm.so.1 ./Root/softGL/lib/pkgconfig/gbm.pc ```

Michael Catanzaro

Comment 4 2018-11-15 17:18:23 PST

Hmm, questionable indeed

Note You need to log in before you can comment on or make changes to this bug.