Bug 19171

Summary: [GTK] GTypes for enumeration
Product: WebKit Reporter: Marco Barisione <marco.barisione>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jmalonzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 16562    
Attachments:
Description Flags
Generate webkit-enum-types.h and .cpp
none
Generate webkit-enum-types.h and .cpp alp: review+

Marco Barisione
Reported 2008-05-21 11:53:23 PDT
WebKit doesn't have gobject types for enums, so they cannot be used as properties.
Attachments
Generate webkit-enum-types.h and .cpp (4.83 KB, patch)
2008-05-21 12:05 PDT, Marco Barisione 		no flags
DetailsFormatted DiffDiff
Generate webkit-enum-types.h and .cpp (4.91 KB, patch)
2008-06-12 11:15 PDT, Marco Barisione 		alp: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marco Barisione
Comment 1 2008-05-21 12:05:07 PDT
Created attachment 21273 [details] Generate webkit-enum-types.h and .cpp
Jan Alonzo
Comment 2 2008-05-22 06:21:56 PDT
*** Bug 16119 has been marked as a duplicate of this bug. ***
Jan Alonzo
Comment 3 2008-05-29 06:30:54 PDT
Rather than using sed, is it better to use /*< underscore_name=foo >*/ in beside the enum decl?
Eric Seidel (no email)
Comment 4 2008-06-06 13:42:51 PDT
Comment on attachment 21273 [details] Generate webkit-enum-types.h and .cpp Um. I have no clue if this is right or not. Looks sane to me, but someone from GTK land should review.
Marco Barisione
Comment 5 2008-06-12 08:09:05 PDT
(In reply to comment #3) > Rather than using sed, is it better to use /*< underscore_name=foo >*/ in > beside the enum decl? I didn't know of its existence and on #gnome-hackers everyone suggested to use sed. What I don't like of underscore_name is that you have to remember to put it everywhere and if you forget it you will probably realise the error only when someone will start using a WebKit enum type for a property. What do you prefer: the clean and error prone way or the ugly but working one? ;)
Jan Alonzo
Comment 6 2008-06-12 08:16:21 PDT
Working is good =)
Marco Barisione
Comment 7 2008-06-12 11:15:25 PDT
Created attachment 21663 [details] Generate webkit-enum-types.h and .cpp Same patch but that doesn't break out-of-tree builds.
Alp Toker
Comment 8 2008-06-17 08:46:23 PDT
Comment on attachment 21663 [details] Generate webkit-enum-types.h and .cpp Please keep an eye on the bot when landing this to avoid build breakage.
Jan Alonzo
Comment 9 2008-06-18 04:38:58 PDT
Landed in r34646
Note You need to log in before you can comment on or make changes to this bug.