Bug 191695

Summary:

Document should throttle style recalc even when m_pendingStyleRecalcShouldForce is true.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
patch	none

alan

Reported 2018-11-15 09:10:36 PST

Apparently m_pendingStyleRecalcShouldForce means full rebuild and not immediate recalc.

Attachments
Patch (1.52 KB, patch) 2018-11-15 09:13 PST, alan	koivisto: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.17 MB, application/zip) 2018-11-15 10:17 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.48 MB, application/zip) 2018-11-15 17:17 PST, EWS Watchlist	no flags	Details
patch (1.99 KB, patch) 2018-12-10 11:41 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2018-11-15 09:13:02 PST

Created attachment 354942 [details] Patch

EWS Watchlist

Comment 2 2018-11-15 10:17:06 PST

Comment on attachment 354942 [details] Patch Attachment 354942 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10005185 New failing tests: imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html userscripts/insert-stylesheets.html fast/selectors/active-hover-quirks.html fast/selectors/not-active-hover-strict.html fast/selectors/active-quirks.html fast/selectors/not-active-hover-quirks.html fullscreen/fullscreen-env.html fast/selectors/hover-quirks.html

EWS Watchlist

Comment 3 2018-11-15 10:17:08 PST

Created attachment 354953 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-11-15 17:17:33 PST

Comment on attachment 354942 [details] Patch Attachment 354942 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10009582 New failing tests: imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html

EWS Watchlist

Comment 5 2018-11-15 17:17:35 PST

Created attachment 355000 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Antti Koivisto

Comment 6 2018-12-10 11:41:00 PST

Created attachment 356974 [details] patch

WebKit Commit Bot

Comment 7 2018-12-10 12:43:02 PST

Comment on attachment 356974 [details] patch Clearing flags on attachment: 356974 Committed r239041: <https://trac.webkit.org/changeset/239041>

WebKit Commit Bot

Comment 8 2018-12-10 12:43:04 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-12-10 12:44:39 PST

<rdar://problem/46604913>

Note You need to log in before you can comment on or make changes to this bug.