|Summary:||REGRESSION(r238016)[GTK][TestWebKitAPI][Ninja] TestJSC can't compile "Bytecodes.h: No such file or directory"|
|Product:||WebKit||Reporter:||Michael Catanzaro <mcatanzaro>|
|Severity:||Normal||CC:||aboya, annulen, bugs-noreply, calvaris, commit-queue, don.olmstead, Hironori.Fujii, jeremyhu, mcatanzaro, pgriffis, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Michael Catanzaro 2018-11-15 08:36:46 PST
Comment 2 Michael Catanzaro 2018-11-15 08:43:24 PST
Dunno about this. It looks like the directory is listed under private include paths for a reason...? Don?
Comment 3 Alicia Boya García 2018-11-15 08:48:06 PST
Note this error is a flake in the build system. Often after retrying build a couple of times, it works. We'd rather not have to deal with that of course. Possibly related: https://bugs.webkit.org/show_bug.cgi?id=161477
Comment 4 Don Olmstead 2018-11-15 09:10:02 PST
Comment 5 Michael Catanzaro 2018-11-15 10:56:29 PST
(In reply to Don Olmstead from comment #4) > What happens if you just generate the project and then go into the build > directory and do ninja TestJSC? $ mkdir -p WebKitBuild/Debug $ cd WebKitBuild/Debug $ ../../Tools/jhbuild/jhbuild-wrapper --gtk run cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=Debug -DDEVELOPER_MODE=ON -GNinja ../.. $ ../../Tools/jhbuild/jhbuild-wrapper --gtk run ninja TestJSC Without my patch, it fails as shown in comment #0.
Comment 6 Michael Catanzaro 2018-11-15 11:55:25 PST
Comment 7 Michael Catanzaro 2018-11-15 12:10:09 PST
Comment 8 Don Olmstead 2018-11-15 12:13:11 PST
I have a feeling that it'd be safer if we enumerated the DerivedSources headers that need to be copied so CMake understands all the dependencies. I'll let Fujii chime in there.
Comment 9 Michael Catanzaro 2018-11-15 12:17:37 PST
*** Bug 161477 has been marked as a duplicate of this bug. ***
Comment 10 Fujii Hironori 2018-11-15 18:31:41 PST
Comment 11 Fujii Hironori 2018-11-15 20:04:04 PST
Comment 13 Michael Catanzaro 2018-11-16 07:53:14 PST
Comment 14 Michael Catanzaro 2018-11-16 07:54:42 PST
(In reply to Michael Catanzaro from comment #13) > I fear we're going to have this same problem in other tests, on other ports. I guess bug #182757 is evidence enough of that.
Comment 15 Fujii Hironori 2018-11-16 16:26:10 PST
Comment 17 Fujii Hironori 2018-11-18 19:59:45 PST
Comment 18 Michael Catanzaro 2018-11-19 08:01:34 PST
Comment 19 WebKit Commit Bot 2018-11-19 08:26:48 PST
Comment on attachment 355247 [details] Patch Clearing flags on attachment: 355247 Committed r238374: <https://trac.webkit.org/changeset/238374>
Comment 20 WebKit Commit Bot 2018-11-19 08:26:50 PST
All reviewed patches have been landed. Closing bug.