Summary: | [GTK] Several compositing tests failing since r238090 "Make compositing updates incremental" | ||
---|---|---|---|
Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | bugs-noreply, mcatanzaro, simon.fraser |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Miguel Gomez
2018-11-15 07:24:10 PST
compositing/overflow/clip-descendents.html [ Failure ] This seems to be related to r230890 as well, but the diff is different from the other ones: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/compositing/repaint/absolute-painted-into-composited-ancestor-actual.txt @@ -1,5 +1,4 @@ (repaint rects - (rect 0 0 200 200) (rect 300 0 200 200) ) (GraphicsLayer And (In reply to Miguel Gomez from comment #1) > compositing/overflow/clip-descendents.html [ Failure ] > > This seems to be related to r230890 as well, but the diff is different from > the other ones: Sorry, this is failing due to the drawsContent flag as well, this is the diff --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/compositing/overflow/clip-descendents-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/compositing/overflow/clip-descendents-actual.txt @@ -36,6 +36,7 @@ (offsetFromRenderer width=20 height=10) (position 48.00 230.00) (bounds 60.00 70.00) + (drawsContent 1) (children 1 (GraphicsLayer (offsetFromRenderer width=20 height=10) @@ -55,6 +56,7 @@ (offsetFromRenderer width=20 height=10) (position 240.00 230.00) (bounds 60.00 70.00) + (drawsContent 1) (children 1 (GraphicsLayer (offsetFromRenderer width=20 height=10) compositing/repaint/absolute-painted-into-composited-ancestor.html [ Failure ] This is the one that happens also due to r238090 but is not related to the drawsContent flag. This is the diff --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/compositing/repaint/absolute-painted-into-composited-ancestor-actual.txt @@ -1,5 +1,4 @@ (repaint rects - (rect 0 0 200 200) (rect 300 0 200 200) ) (GraphicsLayer (In reply to Miguel Gomez from comment #1) > compositing/overflow/clip-descendents.html [ Failure ] > > This seems to be related to r230890 as well, but the diff is different from > the other ones: > > --- > /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/ > compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt > +++ > /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/ > compositing/repaint/absolute-painted-into-composited-ancestor-actual.txt > @@ -1,5 +1,4 @@ > (repaint rects > - (rect 0 0 200 200) > (rect 300 0 200 200) > ) > (GraphicsLayer I changed repaint stuff in r237942, but that should have added repaints, not removed them. (In reply to Miguel Gomez from comment #0) > Curiously, all of this tests produce almost the expected outcome except that > some of the layers have the drawsContent flag set to 1 when it's not > expected. Probably unrelated, but reminds me of bug #187268, where we keep backing store attached when it shouldn't be.... |