Bug 191675

Summary:

[JSC] Drop ARM_TRADITIONAL support in LLInt, baseline JIT, and DFG

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, guijemont, keith_miller, mark.lam, saam, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	mark.lam: review+

Yusuke Suzuki

Reported 2018-11-14 23:46:30 PST

[JSC] Drop ARM_TRADITIONAL support in LLInt, baseline JIT, and DFG

Attachments
Patch (176.13 KB, patch) 2018-11-14 23:49 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (178.21 KB, patch) 2018-11-15 00:03 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (179.11 KB, patch) 2018-11-15 00:26 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (179.26 KB, patch) 2018-11-15 00:40 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (191.06 KB, patch) 2018-11-21 19:35 PST, Yusuke Suzuki	mark.lam: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-11-14 23:49:35 PST

Created attachment 354894 [details] Patch

Yusuke Suzuki

Comment 2 2018-11-15 00:03:57 PST

Created attachment 354897 [details] Patch

Yusuke Suzuki

Comment 3 2018-11-15 00:26:40 PST

Created attachment 354898 [details] Patch

Yusuke Suzuki

Comment 4 2018-11-15 00:40:52 PST

Created attachment 354899 [details] Patch

Guillaume Emont

Comment 5 2018-11-15 02:12:18 PST

Thanks for making the patch! Should we wait until DFG support for Armv7 is back in the tree to test this properly? In the meantime, I will test it over the patch in Bug 191548.

Yusuke Suzuki

Comment 6 2018-11-17 01:52:58 PST

(In reply to Guillaume Emont from comment #5) > Thanks for making the patch! > Should we wait until DFG support for Armv7 is back in the tree to test this > properly? > In the meantime, I will test it over the patch in Bug 191548. I think this can be landed separately since ARM and ARMv7 are different architectures.

Yusuke Suzuki

Comment 7 2018-11-20 15:37:37 PST

Ping?

Yusuke Suzuki

Comment 8 2018-11-21 18:56:42 PST

Ping?

Yusuke Suzuki

Comment 9 2018-11-21 19:35:12 PST

Created attachment 355456 [details] Patch

Mark Lam

Comment 10 2018-11-21 20:50:23 PST

Comment on attachment 355456 [details] Patch r=me