Bug 191666

Summary: DragImage should have a complete default implementation
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, don.olmstead, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ross Kirsling
Reported 2018-11-14 16:40:01 PST
DragImage should have a complete default implementation
Attachments
Patch (5.67 KB, patch)
2018-11-14 16:41 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2018-11-15 09:49 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-11-14 16:41:33 PST
Created attachment 354870 [details] Patch
Don Olmstead
Comment 2 2018-11-14 17:43:02 PST
Comment on attachment 354870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354870&action=review Probably want the notImplemented in all of them. Otherwise LGTM > Source/WebCore/platform/DragImage.cpp:287 > + return { 0, 0 }; notImplemented() > Source/WebCore/platform/DragImage.cpp:292 > +} notImplemented() > Source/WebCore/platform/DragImage.cpp:296 > + return nullptr; notImplemented() > Source/WebCore/platform/DragImage.cpp:300 > +{ notImplemented()
Ross Kirsling
Comment 3 2018-11-15 09:49:38 PST
Created attachment 354948 [details] Patch
WebKit Commit Bot
Comment 4 2018-11-15 12:24:03 PST
Comment on attachment 354948 [details] Patch Clearing flags on attachment: 354948 Committed r238239: <https://trac.webkit.org/changeset/238239>
WebKit Commit Bot
Comment 5 2018-11-15 12:24:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-15 12:25:29 PST
<rdar://problem/46103982>
Note You need to log in before you can comment on or make changes to this bug.