Bug 19163

Summary: Tweak http/tests/security layout tests so they run on Firefox
Product: WebKit Reporter: James Ren <jamesjren>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, collinj, sylvain.pasche
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://crypto.stanford.edu/websec/cross-testing/
Attachments:
Description Flags
Work-in-progress patch
none
patch
none
updated patch with comments from weinig and othermaciej sam: review+

James Ren
Reported 2008-05-20 21:07:00 PDT
I've been working on running the WebKit security LayoutTests in Firefox. I've implemented the LayoutTest controller for Firefox, but a few of the LayoutTests don't run to completion on Firefox. This is usually because Firefox throws an exception when an access is forbidden, but WebKit logs to the error console. We should tweak our security LayoutTests to run on Firefox. I'll attach a patch shortly with the needed tweaks.
Attachments
Work-in-progress patch (36.99 KB, patch)
2008-05-20 21:12 PDT, James Ren 		no flags
DetailsFormatted DiffDiff
patch (38.40 KB, patch)
2008-05-26 14:17 PDT, James Ren 		no flags
DetailsFormatted DiffDiff
updated patch with comments from weinig and othermaciej (38.58 KB, patch)
2008-05-26 15:04 PDT, James Ren 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Ren
Comment 1 2008-05-20 21:12:58 PDT
Created attachment 21266 [details] Work-in-progress patch Here is a work-in-progress patch.
James Ren
Comment 2 2008-05-26 14:17:54 PDT
Created attachment 21351 [details] patch Added a ChangeLog. Added new expected results.
James Ren
Comment 3 2008-05-26 15:04:36 PDT
Created attachment 21352 [details] updated patch with comments from weinig and othermaciej Removed tabs in ChangeLog Added log messages for exceptions thrown when trying to get a cross-domain document.
James Ren
Comment 4 2008-05-26 16:59:44 PDT
patch landed in 34142
Note You need to log in before you can comment on or make changes to this bug.