| Summary: | [WinCairo][WebKitTestRunner] Test contents window is displayed while testing. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, Basuke.Suzuki, bfulgham, commit-queue, Hironori.Fujii, lforschler, pvollan, takashi.komori | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Windows 10 | ||||||||
| Attachments: |
|
||||||||
|
Description
Basuke Suzuki
2018-11-13 12:21:51 PST
I don't know Windows detail, but also process is visible in task bar. Created attachment 355037 [details]
Patch
DumpRenderTree displays test window in out of display area. (x<0, y<0) This patch does same thing. We can hide taskbar button by specifying WS_EX_TOOLWINDOW as argument of CreateWindowEX. Comment on attachment 355037 [details]
Patch
LGTM
Comment on attachment 355037 [details] Patch Clearing flags on attachment: 355037 Committed r238296: <https://trac.webkit.org/changeset/238296> All reviewed patches have been landed. Closing bug. This isn’t right fix. I’ll fix the next week. (In reply to Fujii Hironori from comment #9) > This isn’t right fix. I’ll fix the next week. Komori-san said this is what DumpRenderTree does, please fix that also if this isn't the right fix. (In reply to Basuke Suzuki from comment #10) > Komori-san said this is what DumpRenderTree does, please fix that also if > this isn't the right fix. I didn't know that. I wanted to hide the window by not calling ShowWindow. I will do it another bug. Created attachment 355303 [details]
Patch
If we don't want to call ShowWindow, we have to send WM_PAINT message to webview because BitBlt doesn't work to hidden window.
WM_PAINT is wrong. WM_PRINT |