Bug 191593

Summary: [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, fujii.hironori, lforschler, pvollan, takashi.komori
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   
Attachments:
Description Flags
Patch
none
Patch none

Basuke Suzuki
Reported 2018-11-13 12:21:51 PST
It doesn't displayed on DumpRenderTree.
Attachments
Patch (1.78 KB, patch)
2018-11-16 02:49 PST, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Patch (1.09 KB, patch)
2018-11-19 17:56 PST, Takashi Komori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-11-13 12:25:46 PST
I don't know Windows detail, but also process is visible in task bar.
Takashi Komori
Comment 2 2018-11-16 02:49:08 PST
Created attachment 355037 [details] Patch
Takashi Komori
Comment 3 2018-11-16 02:54:14 PST
DumpRenderTree displays test window in out of display area. (x<0, y<0) This patch does same thing.
Takashi Komori
Comment 4 2018-11-16 03:24:34 PST
We can hide taskbar button by specifying WS_EX_TOOLWINDOW as argument of CreateWindowEX.
Basuke Suzuki
Comment 5 2018-11-16 09:57:08 PST
Comment on attachment 355037 [details] Patch LGTM
WebKit Commit Bot
Comment 6 2018-11-16 12:18:57 PST
Comment on attachment 355037 [details] Patch Clearing flags on attachment: 355037 Committed r238296: <https://trac.webkit.org/changeset/238296>
WebKit Commit Bot
Comment 7 2018-11-16 12:18:58 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-16 14:36:44 PST
<rdar://problem/46140101>
Fujii Hironori
Comment 9 2018-11-16 14:45:55 PST
This isn’t right fix. I’ll fix the next week.
Basuke Suzuki
Comment 10 2018-11-16 18:07:46 PST
(In reply to Fujii Hironori from comment #9) > This isn’t right fix. I’ll fix the next week. Komori-san said this is what DumpRenderTree does, please fix that also if this isn't the right fix.
Fujii Hironori
Comment 11 2018-11-18 21:58:47 PST
(In reply to Basuke Suzuki from comment #10) > Komori-san said this is what DumpRenderTree does, please fix that also if > this isn't the right fix. I didn't know that. I wanted to hide the window by not calling ShowWindow. I will do it another bug.
Takashi Komori
Comment 12 2018-11-19 17:56:35 PST
Created attachment 355303 [details] Patch If we don't want to call ShowWindow, we have to send WM_PAINT message to webview because BitBlt doesn't work to hidden window.
Takashi Komori
Comment 13 2018-11-19 17:58:41 PST
WM_PAINT is wrong. WM_PRINT
Note You need to log in before you can comment on or make changes to this bug.