Bug 191587 – [MediaStream] Observer AVCaptureDevice "suspended" property

• Component: WebRTC
• Status: RESOLVED FIXED

[Eric Carlson]

On macOS the AVCaptureDevice property "suspended" changes when the device stops/resumes producing data because, e.g. the laptop lid is closed. Changes to this property should trigger mediaDevices.ondevicechange and MediaStreamTrack.onmute/MediaStreamTrack.onunmute events.

[Radar WebKit Bug Importer]

<rdar://problem/46030598>

[Eric Carlson]

Created attachment 354675 [details]
Patch

[youenn fablet]

Comment on attachment 354675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354675&action=review

> Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h:72
> +    RetainPtr<NSMutableArray> m_AVCaptureDevices;

Should it be named m_avCaptureDevices?

> Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm:145
> +        stopObservingDevices(scratchArray.get());

I would tend to move the computation of removed devices in stopObservingDevices.
That way, it is clear that we are doing the right thing in terms of begin/stop observing.
It seems we might iterate twice over currentDevices but that might not be a big deal.

s/beginObserving/startObserving?

> Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm:159
> +        deviceList.append(captureDevice);

WTFMove(captureDevice).

> Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm:171
> +        m_devices = deviceList;

WTFMove(deviceList);

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:556
> +        notifyMutedChange(isSuspended);

notifyMutedChange is checking whether muted == m_muted, so we might be able to just write;
notifyMutedChange([m_device isSuspended]);

[Eric Carlson]

Created attachment 354697 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354697 [details]
Patch for landing

Clearing flags on attachment: 354697

Committed r238145: <https://trac.webkit.org/changeset/238145>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.