Bug 191586

Summary: [GStreamer] Enhance debugging by making sure to print the pipeline in MediaPlayerPrivateGStreamer
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Thibault Saunier
Reported 2018-11-13 06:17:07 PST
[GStreamer] Enhance debugging by making sure to print the pipeline in MediaPlayerPrivateGStreamer
Attachments
Patch (33.77 KB, patch)
2018-11-13 06:17 PST, Thibault Saunier
no flags
Patch for landing (33.35 KB, patch)
2018-11-20 06:48 PST, Thibault Saunier
no flags
Patch for landing (33.36 KB, patch)
2018-11-20 06:53 PST, Thibault Saunier
no flags
Thibault Saunier
Comment 1 2018-11-13 06:17:51 PST
WebKit Commit Bot
Comment 2 2018-11-13 16:17:39 PST
Comment on attachment 354669 [details] Patch Rejecting attachment 354669 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 354669, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=354669&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191586&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 354669 from bug 191586. Fetching: https://bugs.webkit.org/attachment.cgi?id=354669 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Xabier Rodriguez-Calvar']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Hunk #24 FAILED at 1327. Hunk #25 succeeded at 1341 (offset -5 lines). Hunk #26 succeeded at 1352 (offset -5 lines). Hunk #27 succeeded at 1396 (offset -5 lines). Hunk #28 succeeded at 1419 (offset -5 lines). Hunk #29 succeeded at 1429 (offset -5 lines). Hunk #30 succeeded at 1614 (offset -5 lines). Hunk #31 succeeded at 1625 (offset -5 lines). Hunk #32 succeeded at 1647 (offset -5 lines). Hunk #33 succeeded at 1702 (offset -5 lines). Hunk #34 succeeded at 1737 (offset -5 lines). Hunk #35 succeeded at 1762 (offset -5 lines). Hunk #36 succeeded at 1782 (offset -5 lines). Hunk #37 succeeded at 1806 (offset -5 lines). Hunk #38 succeeded at 1863 (offset -5 lines). Hunk #39 succeeded at 1906 (offset -5 lines). Hunk #40 succeeded at 1931 (offset -5 lines). Hunk #41 succeeded at 1962 (offset -5 lines). Hunk #42 succeeded at 1986 (offset -5 lines). Hunk #43 succeeded at 2021 (offset -5 lines). Hunk #44 succeeded at 2031 (offset -5 lines). Hunk #45 succeeded at 2134 (offset -5 lines). Hunk #46 succeeded at 2155 (offset -5 lines). Hunk #47 succeeded at 2174 (offset -5 lines). Hunk #48 succeeded at 2415 (offset -5 lines). Hunk #49 succeeded at 2433 (offset -5 lines). Hunk #50 succeeded at 2571 (offset -5 lines). 1 out of 50 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Xabier Rodriguez-Calvar']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9979015
Thibault Saunier
Comment 3 2018-11-20 06:48:12 PST
Created attachment 355343 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-11-20 06:50:48 PST
Comment on attachment 355343 [details] Patch for landing Rejecting attachment 355343 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355343, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/10088464
Thibault Saunier
Comment 5 2018-11-20 06:53:04 PST
Created attachment 355344 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-11-20 07:30:29 PST
Comment on attachment 355344 [details] Patch for landing Clearing flags on attachment: 355344 Committed r238396: <https://trac.webkit.org/changeset/238396>
WebKit Commit Bot
Comment 7 2018-11-20 07:30:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-20 07:31:37 PST
Note You need to log in before you can comment on or make changes to this bug.