Summary: | [cairo] BackingStore::incorporateUpdate should use CompositeCopy to support drawsBackground=false in general Cairo ports | ||
---|---|---|---|
Product: | WebKit | Reporter: | Tomoki Imai <tomoki.imai> |
Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | cgarcia, commit-queue, don.olmstead, webkit-bug-importer, zan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: |
Description
Tomoki Imai
2018-11-12 21:02:25 PST
Created attachment 354644 [details] Actual result of the testcase At first, MiniBrowser opens WebKitGTK+ webpage. After that, I opened Attachment 354641 [details]. Created attachment 354645 [details]
Use CompositeCopy to update bitmap to overwrite existing surface
We should set graphicsContext.setCompositeOperation(WebCore::CompositeCopy) before updating surface.
We should overwrite existing surface by the source even if it contains non opaque parts.
Created attachment 354649 [details]
Use CompositeCopy to update bitmap to overwrite existing surface
I updated ChangeLog as the bugtitle doesn't match to bugzilla, and the style is different from the others.
I guess we can get rid of GTK+ specific code from BackingStore::incorporateUpdate if user-defined background color is used in WebProcess side. https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp?rev=238057#L2817 Comment on attachment 354649 [details]
Use CompositeCopy to update bitmap to overwrite existing surface
Ok.
Comment on attachment 354649 [details] Use CompositeCopy to update bitmap to overwrite existing surface Clearing flags on attachment: 354649 Committed r238379: <https://trac.webkit.org/changeset/238379> All reviewed patches have been landed. Closing bug. |