Bug 191551

Summary:

webkitpy: Check for specific process instead of using data migrator

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	aakash_jain: review+

Jonathan Bedard

Reported 2018-11-12 10:00:24 PST

Previously, we used data migrator as a proxy for simulated devices being booted. This is imperfect because it's possible that the data migrator gets stuck but the device is still usable. Instead, there are specific processes that can be checked to determine if a device is booted or not.

Attachments
Patch (5.46 KB, patch) 2018-11-12 10:08 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (5.59 KB, patch) 2018-11-12 10:58 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (1.46 KB, patch) 2018-11-15 11:37 PST, Jonathan Bedard	aakash_jain: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-11-12 10:01:20 PST

<rdar://problem/45993156>

Jonathan Bedard

Comment 2 2018-11-12 10:08:42 PST

Created attachment 354565 [details] Patch

Aakash Jain

Comment 3 2018-11-12 10:34:06 PST

Comment on attachment 354565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354565&action=review rs=me > Tools/Scripts/webkitpy/xcode/simulated_device.py:497 > + def is_usable(self, force_update=False): no caller of this method seems to be using force_update. Do we need this parameter? > Tools/Scripts/webkitpy/xcode/simulated_device.py:506 > + return True Nit: might consider adding a log statement here.

Jonathan Bedard

Comment 4 2018-11-12 10:58:04 PST

Created attachment 354570 [details] Patch

WebKit Commit Bot

Comment 5 2018-11-12 11:59:44 PST

Comment on attachment 354570 [details] Patch Clearing flags on attachment: 354570 Committed r238103: <https://trac.webkit.org/changeset/238103>

WebKit Commit Bot

Comment 6 2018-11-12 11:59:45 PST

All reviewed patches have been landed. Closing bug.

Jonathan Bedard

Comment 7 2018-11-15 11:37:28 PST

Reopening to attach new patch.