Bug 191527

Summary: [WebAuthn] Make CtapHidAuthenticator/U2fHidAuthenticator to CtapAuthenticator/U2fAuthenticator
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, cdumez, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Description Jiewen Tan 2018-11-11 18:11:38 PST 
Make CtapHidAuthenticator to CtapAuthenticator, and make a ABC for CTAPHidDriver, called CTAPDriver, such that we will have a better polymorphism model for authenticators that uses the same protocol but different transports.
Comment 1 Radar WebKit Bug Importer 2019-08-12 18:43:03 PDT 
<rdar://problem/54237146>
Comment 2 Jiewen Tan 2019-08-12 18:51:24 PDT 
Created attachment 376125 [details]
Patch
Comment 3 Jiewen Tan 2019-08-12 21:05:05 PDT 
Created attachment 376134 [details]
Patch
Comment 4 Jiewen Tan 2019-08-12 21:47:50 PDT 
Created attachment 376138 [details]
Patch
Comment 5 Jiewen Tan 2019-08-13 11:14:06 PDT 
Comment on attachment 376138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376138&action=review

> Source/WebKit/ChangeLog:9
> +        This patch makes a ABC CtapDriver, which suffers as an interface for CtapAuthenticator/U2fAuthenticator to use,

suffers => services
Comment 6 Chris Dumez 2019-08-13 13:32:41 PDT 
Comment on attachment 376138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376138&action=review

>> Source/WebKit/ChangeLog:9
>> +        This patch makes a ABC CtapDriver, which suffers as an interface for CtapAuthenticator/U2fAuthenticator to use,
> 
> suffers => services

I do not understand this sentence, even after your typo fix.
Comment 7 Jiewen Tan 2019-08-13 13:38:09 PDT 
Comment on attachment 376138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376138&action=review

Thanks Chris for r+ this patch.

>>> Source/WebKit/ChangeLog:9
>>> +        This patch makes a ABC CtapDriver, which suffers as an interface for CtapAuthenticator/U2fAuthenticator to use,
>> 
>> suffers => services
> 
> I do not understand this sentence, even after your typo fix.

I would expand the sentence to include a description of the CtapDriver. The CtapDriver is an abstract interface for all drivers that implements the CTAP protocol for different transports, i.e. HID, NFC, BLE ......
Comment 8 Jiewen Tan 2019-08-13 13:43:13 PDT 
Committed r248631: <https://trac.webkit.org/changeset/248631>