Bug 191479

Summary: [MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2018-11-09 12:12:08 PST
AVVideoCaptureSource reports incorrect size when frames are scaled
Attachments
Patch (6.45 KB, patch)
2018-11-09 12:25 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-09 12:13:15 PST
<rdar://problem/45952201>
Eric Carlson
Comment 2 2018-11-09 12:25:00 PST
Created attachment 354371 [details] Patch
youenn fablet
Comment 3 2018-11-09 13:18:46 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=354371&action=review > Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:307 > + continue; exactSizePreset seems to be set above and there is a continue just after it. Maybe we could just have a continue in case we set aspectRatioPreset 4 lines above? > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:523 > m_buffer = &sample.get(); Do we need m_buffer/shutdownCaptureSession anymore?
WebKit Commit Bot
Comment 4 2018-11-09 13:26:23 PST
Comment on attachment 354371 [details] Patch Clearing flags on attachment: 354371 Committed r238053: <https://trac.webkit.org/changeset/238053>
WebKit Commit Bot
Comment 5 2018-11-09 13:26:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.