Bug 191457 – commit time returned by '/api/measurement-set' should match the one returned by '/api/commits'.

• Component: New Bugs
• Status: RESOLVED FIXED

commit time returned by '/api/measurement-set' should match the one returned by '/api/commits'.

Created attachment 354316 [details]
Patch

[Dean Jackson]

Comment on attachment 354316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354316&action=review

> Websites/perf.webkit.org/public/include/db.php:106
> +            // Keep 5 decimal digit to match postgres timestamp behavior.

Typo: digits

Created attachment 354454 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 354454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354454&action=review

> Websites/perf.webkit.org/public/include/db.php:105
>          if ($dot_index !== FALSE)

Per WebKit's styling guideline, you'd need { ~ } around the comment & the statement.
Even when there is a single statement, when there is an additional line used for a comment, you'd need { ~ }.

> Websites/perf.webkit.org/public/include/db.php:108
> +            $timestamp_in_ms += round(floatval(substr($time_str, $dot_index)), 5) * 1000;

Did you verify that postgres rounds up 5?
Not even/odd or a round-down? See http://php.net/manual/en/function.round.php for options.

Landed in r238164.