Bug 191438

Summary:

Web Inspector: Potential for watch expressions to never show results

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2018-11-08 15:06:20 PST

Potential for watch expressions to never show results

I'm not sure how this would be possible, but watch expressions might not be resolving a Promise. It should always resolve the Promise here.

Comment 1 Joseph Pecoraro 2018-11-08 15:08:05 PST

Created attachment 354280 [details]
[PATCH] Proposed Fix

Comment 2 Matt Baker 2018-11-08 15:19:20 PST

Comment on attachment 354280 [details]
[PATCH] Proposed Fix

r=me

Comment 3 WebKit Commit Bot 2018-11-08 15:44:32 PST

Comment on attachment 354280 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 354280

Committed r238005: <https://trac.webkit.org/changeset/238005>

Comment 4 WebKit Commit Bot 2018-11-08 15:44:33 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-11-08 15:45:24 PST

<rdar://problem/45926682>

Comment 6 Devin Rousso 2018-11-08 16:51:47 PST

Comment on attachment 354280 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354280&action=review

> Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js:-313
> -                    resolve(propertyDescriptor);

If `evaluateInWindow` becomes `async`, this could cause the order of properties to be different (depending on the order that each promise resolves).  This isn't an issue right now, especially considering that `WI.ObjectTreeView.comparePropertyDescriptors` sorts the list after the fact.  Just something to consider :)