Bug 191409

Summary: [Win] Compile Service Worker support
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Service WorkersAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, don.olmstead, mcatanzaro, stephan.szabo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Support compiling service workers with clang-cl on windows.
none
Support compiling service workers with clang-cl on windows, moving export other way none

Don Olmstead
Reported 2018-11-07 18:06:16 PST
Currently there are compilation errors around ENABLE(SERVICE_WORKER) in Windows.
Attachments
Support compiling service workers with clang-cl on windows. (1.97 KB, patch)
2018-11-14 10:11 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Support compiling service workers with clang-cl on windows, moving export other way (2.57 KB, patch)
2018-11-14 10:33 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2018-11-14 10:11:03 PST
Created attachment 354827 [details] Support compiling service workers with clang-cl on windows.
Stephan Szabo
Comment 2 2018-11-14 10:33:46 PST
Created attachment 354830 [details] Support compiling service workers with clang-cl on windows, moving export other way Trying it with making the class exported and not the members (putting this up to try on bots while I test win build).
Basuke Suzuki
Comment 3 2018-11-14 10:52:34 PST
AFAIK, we don't have http cache implementation so that service worker doesn't work well.
Don Olmstead
Comment 4 2018-11-14 12:29:30 PST
(In reply to Basuke Suzuki from comment #3) > AFAIK, we don't have http cache implementation so that service worker > doesn't work well. Sure but first step is getting it compiled.
WebKit Commit Bot
Comment 5 2018-11-14 13:54:35 PST
Comment on attachment 354830 [details] Support compiling service workers with clang-cl on windows, moving export other way Clearing flags on attachment: 354830 Committed r238196: <https://trac.webkit.org/changeset/238196>
WebKit Commit Bot
Comment 6 2018-11-14 13:54:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-14 13:55:34 PST
<rdar://problem/46074239>
Note You need to log in before you can comment on or make changes to this bug.