Summary: | "min-content" & "max-content" keywords should behave as initial value in block axis (but WebKit improperly treats them as the content-size) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Holbert <dholbert> | ||||||||||
Component: | Layout and Rendering | Assignee: | Rob Buis <rbuis> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, michaelcpuckett, pdr, rbuis, simon.fraser, webkit-bug-importer, zalan | ||||||||||
Priority: | P2 | Keywords: | BrowserCompat, InRadar | ||||||||||
Version: | Safari 12 | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Daniel Holbert
2018-11-07 11:53:27 PST
This is still present in Safari 13. The Chrome issue has been fixed. This is a cross-browser inconsistency for me during development. Animating max-height from max-content to 0 greatly simplifies transitions, but this is not possible in Safari. Created attachment 420939 [details]
Patch
Created attachment 420960 [details]
Patch
Comment on attachment 420960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420960&action=review > LayoutTests/ChangeLog:11 > + Remove test that makes now incorrect assumptions. > + > + * fast/css-intrinsic-dimensions/height-expected.html: Removed. > + * fast/css-intrinsic-dimensions/height.html: Removed. It’s great to remove tests based on incorrect assumptions. This doesn’t explain why it’s OK to have reduced test *coverage*, though. Presumably the reason is either that WPT has thorough testing of this that was already redundant with this test, or that we have plenty of coverage elsewhere (but then I’d expect us to be updating expected results for the progression). Created attachment 421090 [details]
Patch
Committed r273206: <https://commits.webkit.org/r273206> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421090 [details]. |