Bug 191387

Summary: IntersectionObserver GC-dependent tests are flaky
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ali Juma
Reported 2018-11-07 11:38:01 PST
intersection-observer/root-element-deleted.html is flaky on Sierra Release WK2 bot. intersection-observer/target-deleted.html is flaky on the GTK bots. These two tests try to trigger GC, but if they happen to do this while the GC thread is already active, the call to GC will early-out in GCController::garbageCollectNow. This is problematic for two reasons: 1) The test will continue before the already-underway GC is finished; 2) Objects whose last reference was only just released might not be freed by the already-underway GC. To make these tests more robust, we need to do something like what intersection-observer/no-document-leak.html does, and repeatedly trigger GC inside a setInterval().
Attachments
Patch (4.08 KB, patch)
2018-11-07 11:40 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-11-07 11:40:56 PST
Created attachment 354117 [details] Patch
WebKit Commit Bot
Comment 2 2018-11-07 13:00:44 PST
Comment on attachment 354117 [details] Patch Clearing flags on attachment: 354117 Committed r237939: <https://trac.webkit.org/changeset/237939>
WebKit Commit Bot
Comment 3 2018-11-07 13:00:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-11-07 13:01:30 PST
<rdar://problem/45886176>
Note You need to log in before you can comment on or make changes to this bug.