Bug 191369

Summary:

[css-grid] Import additional grid layout test from the WPT suite

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

New Bugs

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, jfernandez, rego, rniwa, svillar, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none

Javier Fernandez

Reported 2018-11-07 09:04:57 PST

Import additional grid layout test from the WPT suite

Attachments
Patch (209.04 KB, patch) 2018-11-07 09:06 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (228.67 KB, patch) 2018-11-07 09:10 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (219.33 KB, patch) 2018-11-07 09:18 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.41 MB, application/zip) 2018-11-07 10:23 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.33 MB, application/zip) 2018-11-07 11:03 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.30 MB, application/zip) 2018-11-07 11:36 PST, EWS Watchlist	no flags	Details
Patch (226.43 KB, patch) 2018-11-10 16:47 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (225.85 KB, patch) 2018-11-11 02:43 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.35 MB, application/zip) 2018-11-11 04:29 PST, EWS Watchlist	no flags	Details
Patch (232.25 KB, patch) 2018-11-11 07:05 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.51 MB, application/zip) 2018-11-11 08:49 PST, EWS Watchlist	no flags	Details
Patch (239.73 KB, patch) 2018-11-11 12:53 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2018-11-07 09:06:04 PST

Created attachment 354096 [details] Patch

Javier Fernandez

Comment 2 2018-11-07 09:10:58 PST

Created attachment 354097 [details] Patch

Javier Fernandez

Comment 3 2018-11-07 09:18:24 PST

Created attachment 354098 [details] Patch

Manuel Rego Casasnovas

Comment 4 2018-11-07 09:33:06 PST

Comment on attachment 354098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354098&action=review Thanks for doing this. r=me if EWSs are happy :-) > LayoutTests/ChangeLog:3 > + Import additional grid layout test from the WPT suite Supernit: Mark this with [css-grid] so it's easier to look later for all the grid changes.

EWS Watchlist

Comment 5 2018-11-07 10:23:54 PST

Comment on attachment 354098 [details] Patch Attachment 354098 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9895005 New failing tests: imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html

EWS Watchlist

Comment 6 2018-11-07 10:23:55 PST

Created attachment 354107 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-11-07 11:03:01 PST

Comment on attachment 354098 [details] Patch Attachment 354098 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9895100 New failing tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html

EWS Watchlist

Comment 8 2018-11-07 11:03:03 PST

Created attachment 354110 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2018-11-07 11:36:46 PST

Comment on attachment 354098 [details] Patch Attachment 354098 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9895493 New failing tests: imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html

EWS Watchlist

Comment 10 2018-11-07 11:36:48 PST

Created attachment 354115 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Javier Fernandez

Comment 11 2018-11-10 16:47:19 PST

Created attachment 354483 [details] Patch

Javier Fernandez

Comment 12 2018-11-11 02:43:28 PST

Created attachment 354500 [details] Patch

EWS Watchlist

Comment 13 2018-11-11 04:29:07 PST

Comment on attachment 354500 [details] Patch Attachment 354500 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9947471 New failing tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html

EWS Watchlist

Comment 14 2018-11-11 04:29:09 PST

Created attachment 354501 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Javier Fernandez

Comment 15 2018-11-11 07:05:10 PST

Created attachment 354503 [details] Patch

EWS Watchlist

Comment 16 2018-11-11 08:49:48 PST

Comment on attachment 354503 [details] Patch Attachment 354503 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9948979 New failing tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html

EWS Watchlist

Comment 17 2018-11-11 08:49:50 PST

Created attachment 354505 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Javier Fernandez

Comment 18 2018-11-11 12:53:07 PST

Created attachment 354509 [details] Patch

WebKit Commit Bot

Comment 19 2018-11-11 14:22:42 PST

Comment on attachment 354509 [details] Patch Clearing flags on attachment: 354509 Committed r238079: <https://trac.webkit.org/changeset/238079>

WebKit Commit Bot

Comment 20 2018-11-11 14:22:44 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 21 2018-11-11 14:23:28 PST

<rdar://problem/45976016>

Note You need to log in before you can comment on or make changes to this bug.