Bug 191354

Summary:

ScalableImageDecoder: don't forcefully decode image data when querying frame completeness, duration

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cgarcia, mcatanzaro, webkit-bug-importer, yoshiaki.jitsukawa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=193648

Attachments:

Description	Flags
Patch	none
WIP	none
Patch	none

Description Zan Dobersek 2018-11-07 01:41:43 PST

ScalableImageDecoder: don't forcefully decode image data when querying frame completeness, duration

Comment 1 Zan Dobersek 2018-11-07 04:19:23 PST

Created attachment 354081 [details]
Patch

Comment 2 Michael Catanzaro 2018-11-07 20:14:06 PST

Comment on attachment 354081 [details]
Patch

Nice commit message.

Comment 3 Zan Dobersek 2018-11-16 02:57:19 PST

Comment on attachment 354081 [details]
Patch

Clearing flags on attachment: 354081

Committed r238275: <https://trac.webkit.org/changeset/238275>

Comment 4 Zan Dobersek 2018-11-16 02:57:24 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-11-16 02:58:50 PST

<rdar://problem/46123406>

Comment 6 Fujii Hironori 2018-11-16 05:35:05 PST

*** Bug 187582 has been marked as a duplicate of this bug. ***

Comment 7 Carlos Garcia Campos 2019-01-10 02:29:40 PST

It seems this caused regressions in layout tests, see:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239819%20(9330)/css3/shapes/shape-outside/shape-image/shape-image-025-diffs.html

Comment 8 Carlos Garcia Campos 2019-01-10 02:56:57 PST

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239819%20(9330)/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/shape-image/shape-image-025-diffs.html

Comment 9 Michael Catanzaro 2019-01-20 12:37:35 PST

Reverted r238275 for reason:

Regressed css3/shapes/shape-outside/shape-image/shape-image-025.html

Committed r240215: <https://trac.webkit.org/changeset/240215>

Comment 10 Zan Dobersek 2019-04-14 03:47:33 PDT

Created attachment 367400 [details]
WIP

Comment 11 Zan Dobersek 2019-04-14 23:45:46 PDT

Created attachment 367412 [details]
Patch

Comment 12 Zan Dobersek 2019-04-16 23:16:07 PDT

Comment on attachment 367412 [details]
Patch

Clearing flags on attachment: 367412

Committed r244372: <https://trac.webkit.org/changeset/244372>

Comment 13 Zan Dobersek 2019-04-16 23:16:13 PDT

All reviewed patches have been landed.  Closing bug.