Bug 191351

Summary:

"/api/report" does not check commit time correctly.

Product:

WebKit

Reporter:

dewei_zhu

Component:

New Bugs

Assignee:

dewei_zhu

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dewei_zhu, rniwa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

dewei_zhu

Reported 2018-11-07 00:48:31 PST

"/api/report' does not check commit time correctly.

Attachments
Patch (5.59 KB, patch) 2018-11-07 00:51 PST, dewei_zhu	rniwa: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

dewei_zhu

Comment 1 2018-11-07 00:51:49 PST

Created attachment 354070 [details] Patch

dewei_zhu

Comment 2 2018-11-07 16:43:10 PST

Landed in r237953. Tracked in <rdar://problem/45894683>

Ryosuke Niwa

Comment 3 2018-11-12 15:48:50 PST

Comment on attachment 354070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354070&action=review > Websites/perf.webkit.org/public/include/report-processor.php:175 > + > + if ($commit_data['time'] && abs(strtotime($commit_row['commit_time']) - strtotime($commit_data['time'])) > 1.0) Why don't we just call Database::to_js_time and check that the difference is less than 1000ms?

Note You need to log in before you can comment on or make changes to this bug.