| Summary: | Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, jeremyj-wk, slewis, thorton, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jer Noble
2018-11-06 14:42:13 PST
Created attachment 354011 [details]
Patch
Created attachment 354013 [details]
Patch
Created attachment 354016 [details]
Patch
Comment on attachment 354016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354016&action=review > Tools/Scripts/git-is-in-range:3 > +USAGE="<commit range> <commit> [commit...]" Another request was given a set of ranges, find the overlapping range. Maybe you should explain what a <commit range> looks like? I assume it is hash1..hash2? Created attachment 362549 [details]
Patch for landing
Created attachment 362550 [details]
Patch for landing
(In reply to Dean Jackson from comment #4) > Comment on attachment 354016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354016&action=review > > > Tools/Scripts/git-is-in-range:3 > > +USAGE="<commit range> <commit> [commit...]" > > Another request was given a set of ranges, find the overlapping range. Okay. Another request I've heard is: given two commits, figure out which is older (and presumably, whether one is reachable from the other). > Maybe you should explain what a <commit range> looks like? I assume it is > hash1..hash2? Good idea. Added a LONG_USAGE. Comment on attachment 362550 [details] Patch for landing Clearing flags on attachment: 362550 Committed r241843: <https://trac.webkit.org/changeset/241843> All reviewed patches have been landed. Closing bug. |