Summary: | Momentum scrolling ends at the wrong place when a scrolling overflow element has a non-zero border | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jonjohnjohnson <hi> | ||||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, dino, ews-watchlist, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari Technology Preview | ||||||||||
Hardware: | Mac | ||||||||||
OS: | macOS 10.12 | ||||||||||
Attachments: |
|
Description
jonjohnjohnson
2018-11-06 12:36:36 PST
I put more elbow grease into isolating the bug to being from a scroller having a border-width set to any length in the same axis of scrolling. Here is an replacement (and more concise) test case: https://jsfiddle.net/9v514o37/ Four scrollers provided, that scroll in the dimension to see lined pattern move through view. Whether horizontal or vertical, reaching the "scrollend" position is chunky and requires extra effort on macOS STP when scrolling in the dimension that also has a border-width value. See the major difference in effort when scrolling blocks that do not have border in that dimension. Sorry for not isolating as well or even correctly with the first test case. Completely ignore that in light of this comment. Created attachment 355350 [details]
Simple testcase
Heh, RenderLayer::visibleContentRectInternal() has: // FIXME: This seems wrong: m_layerSize includes borders. Can we just use the ScrollableArea implementation? Created attachment 355364 [details]
Patch
Comment on attachment 355364 [details] Patch Attachment 355364 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10092782 New failing tests: media/no-fullscreen-when-hidden.html accessibility/ios-simulator/scroll-in-overflow-div.html Created attachment 355370 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 355364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355364&action=review > LayoutTests/fast/scrolling/momentum-scroll-with-borders.html:46 > + let sendMomenumScroll = function() { momenum!!! \( ゚ヮ゚)/ Thanks for being so speedy simon.fraser@apple.com & dino@apple.com |