Summary: | CSS grid elements with justify-content: space-around have extra whitespace, sometimes a lot | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||
Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino, jfernandez, rego, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=844744 | ||||||||
Attachments: |
|
Description
Javier Fernandez
2018-11-06 08:49:19 PST
Created attachment 353971 [details]
Patch
Comment on attachment 353971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353971&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:565 > + // FIXME (jfernandez) Content Alignment should account for this heuristic Nit. Punctuation. > Source/WebCore/rendering/RenderGrid.cpp:1605 > + auto& offset = > + isRowAxis ? m_offsetBetweenColumns : m_offsetBetweenRows; Nit: Should be one line. > Source/WebCore/rendering/RenderGrid.cpp:1624 > + positionOffset = LayoutUnit(); I don't think this line is necessary. > Source/WebCore/rendering/RenderGrid.cpp:1645 > + positionOffset = LayoutUnit(); Nor this one. > Source/WebCore/rendering/RenderGrid.h:42 > + bool isValid() { return positionOffset >= 0 && distributionOffset >= 0; } const Created attachment 353989 [details]
Patch
Comment on attachment 353989 [details] Patch Clearing flags on attachment: 353989 Committed r237884: <https://trac.webkit.org/changeset/237884> All reviewed patches have been landed. Closing bug. |