Summary: | Multiple stress/regexp-compile-oom.js tests are failing on High Sierra Debug and Release JSC testers. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, guijemont, keith_miller, mark.lam, msaboff, ryanhaddad, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=191206 | ||||||
Attachments: |
|
Description
Matt Lewis
2018-11-05 10:03:21 PST
Also fails on a bunch of our linux bots: - WPE Linux 64-bit Debug (Tests) - GTK Linux 64-bit Release Wayland (Tests) - GTK Linux 64-bit Release (Tests) - GTK Linux 64-bit Debug (Tests) - JSCOnly Linux MIPS32el Release - JSCOnly Linux ARMv7 Thumb2 Release - JSCOnly Linux ARMv7 Thumb2 SoftFP Release Patch in the works. Created attachment 353926 [details]
Patch
Comment on attachment 353926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353926&action=review r=me > JSTests/ChangeLog:8 > + Added more test cases and made all test cases runn with the same deeply recursive stack Typo: runn > Source/JavaScriptCore/runtime/RegExpPrototype.cpp:502 > + RETURN_IF_EXCEPTION(scope, encodedJSValue()); Maybe just release the scope before the above call since this is the last thing? That way we avoid the branch (In reply to Saam Barati from comment #5) > Comment on attachment 353926 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353926&action=review > > r=me > > > JSTests/ChangeLog:8 > > + Added more test cases and made all test cases runn with the same deeply recursive stack > > Typo: runn Fixed. > > Source/JavaScriptCore/runtime/RegExpPrototype.cpp:502 > > + RETURN_IF_EXCEPTION(scope, encodedJSValue()); > > Maybe just release the scope before the above call since this is the last > thing? That way we avoid the branch This is here because code called by RegExpConstructor::performMatch() can throw an exception. Committed r237877: <https://trac.webkit.org/changeset/237877> |