Bug 191261

Summary: Calling sender.replaceTrack() twice produces a new transceiver and its corresponding m= section
Product: WebKit Reporter: Iñaki Baz <ibc>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled.
none
Patch
none
Patch for landing none

Iñaki Baz
Reported 2018-11-05 06:59:49 PST
Created attachment 353860 [details] Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled. Scenario: * Have a pc with an audio transceiver for just sending. * Do transceiver.sender.replaceTrack(null) and renegotiate. * Do transceiver.sender.replaceTrack(track) and renegotiate. After that, we have two audio transceivers so two m=audio sections. Of course this should not happen. It works fine in Chrome and Firefox. Script attached.
Attachments
Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled. (2.94 KB, text/javascript)
2018-11-05 06:59 PST, Iñaki Baz 		no flags
Details
Patch (13.37 KB, patch)
2018-11-06 01:45 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.43 KB, patch)
2018-11-06 18:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-11-05 19:46:21 PST
This is a left over of plan B/unified plan migration. Will fix it
youenn fablet
Comment 2 2018-11-06 01:45:31 PST
Created attachment 353952 [details] Patch
Eric Carlson
Comment 3 2018-11-06 07:19:10 PST
Comment on attachment 353952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353952&action=review > Source/WebCore/ChangeLog:11 > + Covered by updated test. Nit: you should mention that you updated webrtc/video-addTransceiver.html to test this.
youenn fablet
Comment 4 2018-11-06 18:17:50 PST
Created attachment 354040 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-11-06 19:24:07 PST
Comment on attachment 354040 [details] Patch for landing Clearing flags on attachment: 354040 Committed r237910: <https://trac.webkit.org/changeset/237910>
WebKit Commit Bot
Comment 6 2018-11-06 19:24:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-06 19:25:26 PST
<rdar://problem/45864192>
youenn fablet
Comment 8 2018-11-06 19:43:46 PST
(In reply to Eric Carlson from comment #3) > Comment on attachment 353952 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353952&action=review > > > Source/WebCore/ChangeLog:11 > > + Covered by updated test. > > Nit: you should mention that you updated webrtc/video-addTransceiver.html to > test this. Thanks for the review. Done!
Note You need to log in before you can comment on or make changes to this bug.