Bug 191229

Summary: [LFC][BFC] Add support for block level non-replaced inflow height percentage
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future none

alan
Reported 2018-11-03 17:03:27 PDT
ssia
Attachments
Patch (8.91 KB, patch)
2018-11-03 17:05 PDT, alan 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (12.74 MB, application/zip)
2018-11-03 18:42 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-11-03 17:05:44 PDT
Created attachment 353785 [details] Patch
EWS Watchlist
Comment 2 2018-11-03 18:42:00 PDT
Comment on attachment 353785 [details] Patch Attachment 353785 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9849264 New failing tests: fast/block/basic/child-block-level-box-with-height-percent.html
EWS Watchlist
Comment 3 2018-11-03 18:42:12 PDT
Created attachment 353788 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Antti Koivisto
Comment 4 2018-11-04 07:35:06 PST
Comment on attachment 353785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353785&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:110 > + auto height = usedHeight ? usedHeight.value() : computedHeightValue(layoutState, layoutBox, FormattingContext::Geometry::HeightType::Normal); HeightType::Normal might be enough?
alan
Comment 5 2018-11-04 07:45:03 PST
Committed r237782: <https://trac.webkit.org/changeset/237782>
Radar WebKit Bug Importer
Comment 6 2018-11-04 07:46:41 PST
<rdar://problem/45791889>
Note You need to log in before you can comment on or make changes to this bug.